Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

internal/gps: fix case mismatch error with multiple dependers #1233

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

glasser
Copy link
Contributor

@glasser glasser commented Oct 2, 2017

What does this do / why do we need it?

Fixes a bad error message added in dep 0.3.1.

Previously, errors like the following could occur:

v0.4.2: Could not introduce github.com/sirupsen/logrus due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/evalphobia/[email protected]" was already established as the case variant for that project root by the following other dependers:
(root)
github.com/docker/docker@8510adf8c856d6f0871650216a0e1d7e6ece46ee

This fix matches the correct behavior when there is only one depender earlier in
the function.

What should your reviewer look out for in this PR?

Is there an opportunity to add a test for this? I didn't see one.

Do you need help or clarification on anything?

No

Which issue(s) does this PR fix?

I didn't file an issue but I did jot down a comment on the PR that introduced this issue: #1079 (comment)

@glasser glasser requested a review from sdboyer as a code owner October 2, 2017 19:28
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

Previously, errors like the following could occur:

  v0.4.2: Could not introduce github.com/sirupsen/logrus due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/evalphobia/[email protected]" was already established as the case variant for that project root by the following other dependers:
  (root)
  github.com/docker/docker@8510adf8c856d6f0871650216a0e1d7e6ece46ee

This fix matches the correct behavior when there is only one depender earlier in
the function.
@glasser glasser force-pushed the glasser/case-mismatch-error branch from 94e05f1 to 681e6f5 Compare October 2, 2017 19:30
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 2, 2017
@glasser
Copy link
Contributor Author

glasser commented Oct 2, 2017

Resubmitted with the email address that has a CLA.

@sdboyer
Copy link
Member

sdboyer commented Oct 4, 2017

yes yes, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants