-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Clean-up and refactor of the Android input implementation #65398
Conversation
95fde2e
to
60c4372
Compare
60c4372
to
10fe8bd
Compare
Fix the bug causing the editor to crash when running the project.
10fe8bd
to
63df48a
Compare
Thanks! |
Should this be considered for a 3.5.1 cherry-pick? Having double-tap and right-click will make the Android editor much more usable, without having to wait for 3.6. |
@Calinou I think it's risky for a For the Android editor, I'm planning to put out a |
:0 omg i am really looking forward to that, thanks for all the hard work |
The first commit cleans up and refactors the Android input implementation:
GodotInputHandler.java
class which is now responsible for setting up and configuring the gesture handler logicprocess_touch_event
for touch,process_mouse_event
for mouse & stylus, andprocess_magnify
andprocess_pan
for scaling and panning gestures.In the process, the PR addresses several existing Android input bugs:
Fixes #8151, #46100, #46101
Supersedes #59760, #54225
The second commit enables the long press, multi-finger panning and scaling gestures for the Godot Android Editor and fixes an input related bug that uses to cause a crash when clicking on the
play
button from the editor window.Addresses some of the issues reported in godotengine/godot-proposals#3931
godot_android_editor_multi_touch_pixel5.mp4
master version