Fix InputEventAction's is_match method ignoring exact_match parameter
#63109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
the
cherrypick:3.x
EricEzaM
approved these changes
Sep 24, 2022
|
Thanks! |
|
I notice the |
|
Yes it should be easy to cherrypick, Git can likely handle the rename fine. If not, it's easy enough to do the change manually when resolving a potential conflict. |
|
Cherry-picked for 3.6 |
timothyqiu
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63108.
I tested it on the linked issue's minimal reproduction project and it seems to be working. I haven't tested it for 3.x, but if this PR gets accepted, I will open a new one for 3.x. I am slightly worried about this change because
InputEventAction'sis_actiondoesn't take anexact_matchparameter at all, but I didn't encounter any issues while testing this.