Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drag start/end signals for Slider #55775

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Add drag start/end signals for Slider #55775

merged 1 commit into from
Jan 7, 2022

Conversation

timothyqiu
Copy link
Member

Resolves #6007

Also provided a value_changed parameter for drag_ended() signal so the user won't need to keep track of the old value manually.

@timothyqiu timothyqiu added enhancement cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Dec 10, 2021
@timothyqiu timothyqiu added this to the 4.0 milestone Dec 10, 2021
@timothyqiu timothyqiu requested review from a team as code owners December 10, 2021 03:30
@timothyqiu timothyqiu requested a review from akien-mga January 7, 2022 10:12
@akien-mga akien-mga merged commit 7640dc2 into godotengine:master Jan 7, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the slider-drag branch January 7, 2022 12:10
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Have "changing" and "changed" signals in Range controls
2 participants
@timothyqiu @akien-mga