Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update render target directly if ARVR mode is off #54258

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

BastiaanOlij
Copy link
Contributor

When using XR plugins like the Oculus Desktop and OpenXR in combination with switching the ARVR mode on for the primary viewport, window resizing will attempt to resize the viewport while the XR server is now in control of this viewport.

This PR makes sure that we do not resize the viewport unless the ARVR mode is turned off, or at the opportune moment when it is on. Should also fix some related issues such as switching transparency.

Fixes #41889

@BastiaanOlij BastiaanOlij added this to the 3.4 milestone Oct 26, 2021
@BastiaanOlij BastiaanOlij self-assigned this Oct 26, 2021
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner October 26, 2021 10:26
@BastiaanOlij
Copy link
Contributor Author

BastiaanOlij commented Oct 26, 2021

@m4gr3d I vaguely remember you had an issue when you switched transparency on with Godot going nutsy with the viewport as well. This should fix that too (though i don't really get why it triggered the behaviour, unless I'm mixing up issues).

@BastiaanOlij BastiaanOlij force-pushed the fix_arvr_resize_issue branch from 78e80c8 to 3bd6088 Compare October 26, 2021 10:40
@akien-mga akien-mga merged commit b6e3d73 into godotengine:3.x Oct 26, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants