Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] [core_bind] Add Thread::is_alive #53490

Merged
merged 1 commit into from
Oct 12, 2021
Merged

[3.x] [core_bind] Add Thread::is_alive #53490

merged 1 commit into from
Oct 12, 2021

Conversation

briansemrau
Copy link
Contributor

3.x version of #53455

This adds the function is_alive to core/bind/Thread.
This also removes the redundant implementation of is_active in favor of core/os/Thread::is_started. Unlike the master PR, this does not rename is_active to preserve compatibility.

@briansemrau briansemrau requested review from a team as code owners October 6, 2021 19:18
@akien-mga akien-mga added this to the 3.4 milestone Oct 6, 2021
@akien-mga akien-mga merged commit 4186c5e into godotengine:3.x Oct 12, 2021
@akien-mga
Copy link
Member

Thanks!

@briansemrau briansemrau deleted the thread-is-alive-3.x branch October 25, 2021 17:35
@akien-mga akien-mga mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@briansemrau @akien-mga