[3.x] Fix 3D moving platform logic #51458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same thing that was already done in 2D, applies moving platform motion by using a call to move_and_collide that excludes the platform itself, instead of making it part of the body motion. Helps with handling walls and slopes correctly when the character walks on the moving platform. Also made some minor adjustments to the 2D version and documentation. Co-authored-by: fabriceci <[email protected]>
pouleyKetchoupp
force-pushed
the
moving-platforms-3d-3.x
branch
from
e7add8e to
da159cd
Compare
akien-mga
approved these changes
Aug 10, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3D physics port of #50166 on 3.x (master version: #51457)
Fixes #30311
Co-authored-by: @fabriceci
Same thing that was already done in 2D, applies moving platform motion by using a call to
move_and_collidethat excludes the platform itself, instead of making it part of the body motion.Helps with handling walls and slopes correctly when the character walks on the moving platform.
Also made some minor adjustments to the 2D version and documentation.