[3.x] Makes shader 'TIME' available in custom functions by default #49509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
shader_time_3.x
branch
2 times, most recently
from
0c544d1 to
90e93ae
Compare
akien-mga
approved these changes
Aug 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37166 (with #37167, #37171 fixes) to 3.x branch.
I tested it with all shader modes: GLES3/GLES2 & Spatial/CanvasItem/Particles
GIF
I made a fixing change to
scene.glsl(GLES3) to make it properly handletimein custom functions of Spatial shader (it was declared after the declaration of custom functions and cannot be handled otherwise).