Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --no-window option for macOS and Linux #43325

Closed
MikeSchulze opened this issue Nov 5, 2020 · 6 comments
Closed

Implement --no-window option for macOS and Linux #43325

MikeSchulze opened this issue Nov 5, 2020 · 6 comments

Comments

@MikeSchulze
Copy link

Godot version:
Godot Engine v3.2.3.stable.mono.official

OS/device including version:
macOS Sierra Version 10.12.6

Issue description:
When i try to run a script via OS.execute() with option --no-window the window pops up.
Under Windows 10 it works as expected but under MacOs the window is not hidden

Steps to reproduce:

class_name GdUnitRunnerClient
extends SceneTree

func _initialize():
  pass
...

execution from a EditorPlugin context

var arguments := Array()
arguments.append("--no-window")
arguments.append("-d")
arguments.append("-s")
arguments.append("res://addons/gdUnit/src/core/GdUnitRunnerClient.gd")

var output = []
_current_runner_process_id = OS.execute(OS.get_executable_path(), arguments, false, output, true);

Minimal reproduction project:

@bruvzg
Copy link
Member

bruvzg commented Nov 5, 2020

On Linux and macOS --no-window is not implemented, here's PR for it #42276.

@akien-mga
Copy link
Member

$ godot --help | grep no-window
  --no-window                      Disable window creation (Windows only). Useful together with --script.

@MikeSchulze
Copy link
Author

ok thanks for this feedback

@akien-mga
Copy link
Member

Let's repurpose this as a feature request to implement --no-window for macOS and Linux I guess, which #42276 can close.

@akien-mga akien-mga changed the title MacOS OS.execute() an script with option --no-window the window is not hidden Implement --no-window option for macOS and Linux Nov 5, 2020
@akien-mga akien-mga added this to the 3.2 milestone Nov 5, 2020
@Riteo
Copy link
Contributor

Riteo commented Nov 17, 2020

Now that the resolving PR has been merged, can this issue be closed?

@Calinou
Copy link
Member

Calinou commented Nov 17, 2020

Closing, as this is now implemented in 3.2 (it will be in 3.2.4beta2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants