Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adding AnimationMixer libraries more intuitive #9893

Closed
Flynsarmy opened this issue Jun 5, 2024 · 2 comments
Closed

Make adding AnimationMixer libraries more intuitive #9893

Flynsarmy opened this issue Jun 5, 2024 · 2 comments

Comments

@Flynsarmy
Copy link

Flynsarmy commented Jun 5, 2024

Describe the project you are working on

Any involving AnimationTrees without an AnimationPlayer in 4.3. For example a third person player character that inherits its animations from a bunch of libraries.

Describe the problem or limitation you are having in your project

Adding libraries to an AnimationTrees libraries field inherited from AnimationMixer is workable but unintuitive.

Here's the current workflow as I understand it:

  1. Expand Libraries field
    image

  2. Set Key type to StringName and Value type to Object
    image

  3. Set your name and drag in your library
    image

  4. Click Add Key/Value Pair
    image

  5. From here, the 'Animation' window appears in the bottom tab. You can open that up then use the 'Manage Animations' window to add further anims/lbraries easier:
    image

Describe the feature / enhancement and how it helps to overcome the problem or limitation

I propose changing the Libraries Inspector row to simply use the 'Manage Animations' window from the beginning. A GUI is much easier to work with and consistent with AnimationPlayer's workflow.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Ideally we'd get something like this inspector buttons proposal implemented (there is a PR for it already) - then the Libraries row could be changed to a 'Manage Animations' button.

If this enhancement will not be used often, can it be worked around with a few lines of script?

It can be worked around a couple of ways:

  1. Use the cumbersome method mentioned above.
  2. Attach an AnimationPlayer the way we have in the past and add animations through it.

Is there a reason why this should be core and not an add-on in the asset library?

It's a usability issue. Using AnimationTree without an AnimationPlayer is being touted as a benefit of the new AnimationMixer resource however actually using AnimationTree in this way as it stands is confusing and error prone due to the number of boilerplate steps.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 5, 2024

Animation tab is always visible and you can use it with AnimationTree right after creating it.

@Flynsarmy
Copy link
Author

Ahh that makes things simpler! I didn't notice the new tab as it doesn't pop up when adding an AnimationTree the way it does when adding an AnimationPlayer despite adding libraries probably being the first thing you'd want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants