Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd/eureka: test failures #542

Closed
peterbourgon opened this issue Jun 4, 2017 · 4 comments
Closed

sd/eureka: test failures #542

peterbourgon opened this issue Jun 4, 2017 · 4 comments
Labels

Comments

@peterbourgon
Copy link
Member

peterbourgon commented Jun 4, 2017

# github.com/go-kit/kit/sd/eureka
.../eureka/integration_test.go:59: instancer.State undefined (type *Instancer has no field or method State)
.../eureka/integration_test.go:77: instancer.State undefined (type *Instancer has no field or method State)
.../eureka/integration_test.go:92: undefined: endpoints
.../eureka/integration_test.go:92: undefined: err
.../eureka/integration_test.go:92: undefined: endpointer in endpointer.Endpoints
.../eureka/integration_test.go:93: undefined: err
.../eureka/integration_test.go:94: undefined: err
.../eureka/integration_test.go:96: undefined: endpoints

https://circleci.com/gh/go-kit/kit/1216

@yurishkuro I reckon this is related to the thing I just merged. Can you knock this one out quickly? I'll look into why Circle isn't running on PRs...

@peterbourgon
Copy link
Member Author

Build forked pull requests

Run builds for pull requests from forks. CircleCI will automatically update the commit status shown on GitHub's pull request page.

This is now turned on.

@yurishkuro
Copy link
Contributor

looking

@yurishkuro
Copy link
Contributor

@peterbourgon an aside question - do you find CircleCI to be better for integration tests than Travis? I'm wondering if we should consider it for Jaeger.

@peterbourgon
Copy link
Member Author

I'm not sure why we decided to run integration tests on Circle rather than Travis. Maybe it was because it had a nicer (read: easier to use) Docker environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants