Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: default StdlibAdapter file key should be "caller" #432

Closed
willfaught opened this issue Jan 11, 2017 · 5 comments
Closed

log: default StdlibAdapter file key should be "caller" #432

willfaught opened this issue Jan 11, 2017 · 5 comments

Comments

@willfaught
Copy link
Contributor

willfaught commented Jan 11, 2017

Not "file". To match the naming of DefaultCaller/UTC.

Open to a PR?

@willfaught willfaught changed the title log: StdlibAdapter default file key should be "caller" log: default StdlibAdapter file key should be "caller" Jan 11, 2017
@peterbourgon
Copy link
Member

Hmm, on a first pass, I don't agree. File is considerably less ambiguous; caller could imply a lot of things. But I'm open to being persuaded. @ChrisHines, any opinion?

@willfaught
Copy link
Contributor Author

Seems to me like the nomenclature should match since they both produce "file:line", whatever the term is. I'm fine with DefaultFile/UTC too.

@willfaught
Copy link
Contributor Author

willfaught commented Jan 11, 2017

Although it's not just the file, it's also the line, so DefaultFile/UTC might be unclear; at least DefaultCaller/UTC implies as much info as file/line.

@ChrisHines
Copy link
Member

I would like to note that only StdlibAdapter actually encodes the key string (and provides a default of "file"). The key of "caller" only appears in examples and tests. I don't think it is a big deal, but if forced to choose I would go with consistency and would agree with @willfaught.

@peterbourgon
Copy link
Member

Oh, I see now. Yes, let's be consistent. I'm down with "caller".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants