-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: default StdlibAdapter file key should be "caller" #432
Comments
Hmm, on a first pass, I don't agree. File is considerably less ambiguous; caller could imply a lot of things. But I'm open to being persuaded. @ChrisHines, any opinion? |
Seems to me like the nomenclature should match since they both produce "file:line", whatever the term is. I'm fine with DefaultFile/UTC too. |
Although it's not just the file, it's also the line, so DefaultFile/UTC might be unclear; at least DefaultCaller/UTC implies as much info as file/line. |
I would like to note that only StdlibAdapter actually encodes the key string (and provides a default of "file"). The key of "caller" only appears in examples and tests. I don't think it is a big deal, but if forced to choose I would go with consistency and would agree with @willfaught. |
Oh, I see now. Yes, let's be consistent. I'm down with "caller". |
Not "file". To match the naming of DefaultCaller/UTC.
Open to a PR?
The text was updated successfully, but these errors were encountered: