New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One of go-kit dependencies is not goroutine safe #424

Closed

gaplyk opened this issue Jan 9, 2017 · 0 comments

Contributor

gaplyk commented Jan 9, 2017

Got a panic in one of dependencies when 2 routines trying to write metrics:
https://github.com/VividCortex/gohistogram/blob/master/numerichistogram.go#L124

As for author comment it is not goroutine safe:
VividCortex/gohistogram#21

One of the options is to add mutex to generic histogram here:
https://github.com/go-kit/kit/blob/master/metrics/generic/generic.go#L121

peterbourgon mentioned this issue

metrics/generic: make VividCortex/gohistogram safe #426

Merged

peterbourgon closed this as completed in #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment