Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send notifications until review gets submitted #4388

Closed
jonasfranz opened this issue Jul 6, 2018 · 4 comments
Closed

Send notifications until review gets submitted #4388

jonasfranz opened this issue Jul 6, 2018 · 4 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@jonasfranz
Copy link
Member

It would be nice if the users of an issue get a notification / action at dashboard after a new review got submitted. At the moment only notifications for review code comment will be sent.

Blocked by #3748
@jonasfranz jonasfranz added type/enhancement An improvement of existing functionality status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Jul 6, 2018
@jonasfranz jonasfranz added this to the 1.x.x milestone Jul 6, 2018
@lafriks lafriks mentioned this issue Jul 6, 2018
Merged
23 tasks
@jonasfranz jonasfranz removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Aug 6, 2018
@jonasfranz
Copy link
Member Author

#3748 got implemented! Ready to get implemented.

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 15, 2019
@stale
Copy link

stale bot commented Feb 19, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Feb 19, 2019
@lafriks lafriks reopened this Feb 19, 2019
@stale stale bot removed the issue/stale label Feb 19, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 19, 2019
@wxiaoguang wxiaoguang mentioned this issue Jul 5, 2022
Open
@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
@delvh
Copy link
Member

delvh commented Apr 29, 2023

I think that's implemented by now?
Feel free to reopen if not.

@delvh delvh closed this as completed Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @lafriks @jonasfranz @delvh