Something is causing a lock on some records on "repositories" table

[andreynering]

• Gitea version (or commit ref): Current master (4bea219)
• Git version: git version 2.10.2.windows.1
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: none

Description

I think it might be PostgreSQL specific, since I tried on try.gitea.io, which uses MariaDB, but couldn't reproduce.

In different installations I saw this issue where it isn't possible to update any information of a repository (e.g. change its name or if it's private or public) or even delete the repo. When you click the Update or Delete button, the request takes forever and nothing happens.

Doing some investigation I found that it's a lock issue in the DB. If I try to update or delete the record in my SQL editor it takes forever and never completes. But if I stop Gitea and try again than it works. If I start Gitea again the lock happens again.

I think it may be an issue with an migration or other startup action (probably a mising commit or rollback), but could not fint it yet. I'm posting here to know it anyone has any idea.

[lunny]

Then have you tested before 4bea219's version ?

[lunny]

I think this should be caused by #1332 which we just merged.

[bkcsoft]

@andreynering Could you verify using this? https://wiki.postgresql.org/wiki/Lock_Monitoring

And get the last N lines from xorm.log :)

[lunny]

@andreynering But this PR is not related with repository operations. @bkcsoft a new question, we need delete all commitstatus when a repo will be deleted.

[bkcsoft]

@lunny Status-API isn't used by anything, and has no Foreign Keys to Repository either (that should probably be fixed though...). So I don't see how it could affect the DB at all 😕

[andreynering]

I noticed this issue during this week, but it may exist even longer. So has nothing to do with the status API just merged.

[bkcsoft]

Well, we found other issues in the Status-API PR anyhow so 💯 #1332 (review) (Double Transactions ❤️ )

[andreynering]

After updating with current master, this was somehow fixed, but I have no idea how. 😱

[lunny]

Since no PR to fix this, I moved it from 1.2.0