feat(keeper)!: use <pkgpath>.<expr> syntax for qeval; <pkgpath>:<path> for qrender #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
moul,
gfanton,
zivkovicmilos,
leohhhn and
a team
as code owners
github-actions
bot
added
🧾 package/realm
moul
reviewed
Jun 18, 2024
|
Related: #2349 |
moul
approved these changes
Jun 18, 2024
Co-authored-by: Manfred Touron <[email protected]>
…to dev/morgan/qeval-newlines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
+ Coverage 54.63% 54.64% +0.01%
==========================================
Files 582 582
Lines 78401 78402 +1
==========================================
+ Hits 42832 42843 +11
+ Misses 32359 32349 -10
Partials 3210 3210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Codecov? :c |
zivkovicmilos
added
the
breaking change
This was referenced Jun 26, 2024
7 tasks
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…> for qrender (gnolang#2382) This is a switch that was discussed with @leohhhn and @moul. It switches the current syntax for qeval, which requires a newline as a separator, to use a dot `.` instead (ie. `gno.land/r/demo/users.MyFunction(123)`). For qrender, this is switched to a colon `:`, like the gnoweb render: `gno.land/r/demo/users:u/morgan`. BREAKING CHANGE: current qeval and qrender calls using the RPC endpoints will have to be changed. No changes are required for gnoclient users. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]> Co-authored-by: Leon Hudak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a switch that was discussed with @leohhhn and @moul. It switches the current syntax for qeval, which requires a newline as a separator, to use a dot
.instead (ie.gno.land/r/demo/users.MyFunction(123)). For qrender, this is switched to a colon:, like the gnoweb render:gno.land/r/demo/users:u/morgan.BREAKING CHANGE: current qeval and qrender calls using the RPC endpoints will have to be changed. No changes are required for gnoclient users.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description