-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Overhaul Github Actions #2040
Conversation
Related with #2013 |
Overall, you seem to be also making a work to ensure that the "standard scenario" for testing is one where doing "go test ./..." just works. I can agree with that; I'd like to see the exceptions we have on the Makefiles (and copied into the CI) reduced as well. However, consider that aside from the They are currently not covered; if you want to test them by adding a daily CI (rather than one at each commit) testing for them then go for it. But the CI should still run these with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2040 +/- ##
===========================================
- Coverage 55.01% 21.79% -33.22%
===========================================
Files 481 24 -457
Lines 67432 2092 -65340
===========================================
- Hits 37097 456 -36641
+ Misses 27318 1619 -25699
+ Partials 3017 17 -3000
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8ac1fd6
to
25ccd0e
Compare
1213b51
to
4a11406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be crazy, but the CI on this PR is significantly faster and snappier 👀
Let's go 🚀
@thehowl did you get a chance to recheck this? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM. a few comments; on the ones from the previous review, please act on them and we should be good to go
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
future. Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
29bd559
to
d4ad4da
Compare
cc/ @ajnavarro, related to #2040
Continues #2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in #2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <[email protected]>
Continues gnolang#2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in gnolang#2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <[email protected]>
Github Actions refactoring
This PR aims to heavily simplify our CI and the way we are running our tests. To remove as much cognitive load as possible, Go default test commands are used for testing (a.k.a
go test ./...
) instead of intricated makefiles.This PR is the first of several PRs cleaning and simplifying the test suite.
On this PR:
contribs
on chore: make contribs/ ci and makefiles dynamic #2013 are applied on this PR (CC @moul) (closes chore: make contribs/ ci and makefiles dynamic #2013)-short
tag taking into account the extra work that it causes when tests are failing only in master because we are not running them on all the PRs. Apart from that, tests that should have been executed on CI are executed now.TODO:
These are some of the missing improvements on this PR that will be addressed in following ones:
-race
flagExtra checks:
BREAKING CHANGE: xxx
message was included in the description