perf: machine string

[petar-dambovaliev]

Make the String method on the Machine struct faster by preallocating a string builder.

issue

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.82%. Comparing base (f660be5) to head (20ea949).
Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
+ Coverage   46.63%   46.82%   +0.18%     
==========================================
  Files         492      492              
  Lines       69624    69767     +143     
==========================================
+ Hits        32472    32670     +198     
+ Misses      34445    34388      -57     
- Partials     2707     2709       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[moul]

do you have some benchmarks to share?

[petar-dambovaliev]

do you have some benchmarks to share?

Benchmark pushed.

current branch

BenchmarkStringLargeData-10    	     212	   4518087 ns/op

master branch

BenchmarkStringLargeData-10    	     172	   6875883 ns/op

[deelawn]

How long does it take to print the machine string if it exceeds memory allocation due to an infinitely recursing function?

[petar-dambovaliev]

How long does it take to print the machine string if it exceeds memory allocation due to an infinitely recursing function?

That issue is being fixed in another PR

[deelawn]

Where does the new code print these headers? I can see one for Realm for not for the others