-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve gnodev logging #1790
Conversation
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
1f8a5df
to
7e95f3f
Compare
Signed-off-by: gfanton <[email protected]>
0880132
to
0f38953
Compare
@gfanton |
@zivkovicmilos |
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 45.08% 45.07% -0.01%
==========================================
Files 464 464
Lines 68014 68023 +9
==========================================
- Hits 30661 30660 -1
- Misses 34778 34786 +8
- Partials 2575 2577 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
bb30dc8
to
4d9483e
Compare
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I played around with this a little. I recorded looms (sorry for two - got cut off):
Loom 1
Loom 2
Seems that genesis TX loading is not working properly and reloading the state is failing for some reason (ungracefully). See the looms, and lets discuss, not fully sure what's up.
EDIT:
OK, I think I figured out what the issue is. Monorepo I used to install this already has a p/demo/memeland
& r/demo/memeland
package & realm, and I was trying to load in the package with the same path. How can we handle this error better?
EDIT2: Yup, can confirm that the above was the issue. Can we handle this edge case? Check already deployed packages against the gno.mods you're trying to run with gnodev
, and error out?
Also, the genesis TXs still aren't being loaded - seems like a separate issue.
@leohhhn Wow! Good catch, thanks! I believe Genesis TX FIle shouldn't load by default during development. It could be loaded with a separate flag, making it a feature rather than an issue 😛. As for the other bug, I'm unsure about the best approach. I'm concerned that overriding a package for the user might cause unexpected behavior. I suggest providing a clear error message for duplicate packages and a flag(?) for users to explicitly override the package. |
Signed-off-by: gfanton <[email protected]>
I'm glad you brought that up: #1883 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, now we have a reference implementation 💯
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for figuring out what the issue was with the panic when exiting or invalid syntax (it turned out to be that I was using Go 1.21 and for some reason it was failing).
Let's tackle other issues and possible improvements I mentioned after merging this 🙏
Signed-off-by: gfanton <[email protected]>
@gfanton is this good to merge? |
@leohhhn I was waiting for potential additional reviews, but i guess we can merge it now |
This PR enhances the
gnodev
logger for easier debugging:--verbose
is specifiedContributors' checklist...
BREAKING CHANGE: xxx
message was included in the description