Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gnokey] Display transaction hash to user after a maketx call #2303

Closed
leohhhn opened this issue Jun 7, 2024 · 1 comment · Fixed by #2309
Closed

[gnokey] Display transaction hash to user after a maketx call #2303

leohhhn opened this issue Jun 7, 2024 · 1 comment · Fixed by #2309

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jun 7, 2024

Description

A user should be able to see the hash of the transaction they submitted with gnokey maketx, once the transaction is complete.
@linhpn99
Copy link
Contributor

linhpn99 commented Jun 7, 2024

Its actually nessesary for both gnokey maketx and gnoclient

@linhpn99 linhpn99 mentioned this issue Jun 8, 2024
Merged
7 tasks
@leohhhn leohhhn linked a pull request Jun 18, 2024 that will close this issue
feat(gnokey): Print out the transaction hash when maketx executes successfully #2309
Merged
7 tasks
@michelleellen michelleellen mentioned this issue Jun 26, 2024
Open
@Kouteki Kouteki moved this from Triage to In Progress in 🧙‍♂️gno.land core team Jun 28, 2024
zivkovicmilos pushed a commit that referenced this issue Jul 22, 2024
@linhpn99
feat(gnokey): Print out the transaction hash when maketx executes suc…
1fbd373 
…cessfully (#2309)

Relate to #2303

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team Jul 22, 2024
gfanton pushed a commit to gfanton/gno that referenced this issue Jul 23, 2024
@linhpn99 @gfanton
feat(gnokey): Print out the transaction hash when maketx executes suc…
ff8aefd 
…cessfully (gnolang#2309)

Relate to gnolang#2303

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gnokey): Print out the transaction hash when maketx executes successfully linhpn99/gno
2 participants
@leohhhn @linhpn99