-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling memory allocation limit for query eval #1506
Comments
Based on discussions from our call today, the suggestions were:
I'm curious if you can provide us some more information:
|
Aside from what Milos said, I should point out that the real solution is necessarily not increasing the allocation limit, but rather addressing synchronous GC: #266. This way, the "allocation" of a contract reflects how much memory it has actually stored, rather than a sum of all of the times it has attempted to store memory. |
I also believe it's more generalizable in the long term to address this problem directly at the language level. While 'external solutions' (I don't know if this is the right expression) such as optimization in SC, are still practical and valuable and should have considered in development process. But some approaches may to be cumbersome or necessitate distinct strategies for each project, which can be restrictive. BTW has there any further discussion about GC related things? |
@petar-dambovaliev |
This should be addressed by sync GC, which should have a reasonable default. We can also expect some users to run special RPC nodes with higher values. In other words, it makes sense to make it configurable while providing a reasonable default. |
Description
In pr #267, max memory cap has been set to 1.5g for qeval with comment
// higher limit for queries
I'm aware of increasing this limit can break rpc service (similar research against ethereum => paper & video
However current limit may not be enough for certain use case.
Question
cc @mconcat @notJoon @dongwon8247 @zivkovicmilos
The text was updated successfully, but these errors were encountered: