-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle port notifications in JetBrains #9908
Comments
Not sure about implementation, maybe we rather move this logic from VS Code to supervisor and rely on notifications API only. We will need to get open/preview notifications API implemented for that though which is rather a big refactoring. |
I needed some guidance so I started an internal chat to speed up knowledge sharing. The outcome of this thread is: Do a refactor of supervisor + VS Code Desktop would be a big change especially to make it backwards compatible. In VS Code Web, we subscribe to supervisor's port status and we listen to status changes. We then emit notifications when a port status has changed. For now, we will proceed with an approach similar to VS Code Web, also for JetBrains IDEs. Useful links:
|
Summary
Show a notification in JetBrains IDEs when a port is ready and exposed
Context
At the moment,
open-preview
andopen-browser
do not work automatically. The user can rungp url <PORT>
and get the URL manually, however there is no information or notification about the port/URL being ready.This is a feature that we have in VS Code, so we should handle supervisor notifications also via JetBrains Gateway
Value
Users are aware that a port has been exposed and their preview URL can be opened
Acceptance Criteria
A notification appears for each port being exposed
Measurement
Not incoming support request about how to open the preview URL from JetBrains Gateway
Out of scope
The text was updated successfully, but these errors were encountered: