Hide license type in admin dashboard when not applicable

[gtsiolis]

Problem to solve

In /admin/license there are some edge cases where license type is not applicable.

Cc @nandajavarma @mrsimonemms because #9763

Screenshot from the license page in an instance

Proposal

When the license information is not applicable, let's hide the key-value element altogether.

Since we're here, we could also:

• 🅰️ keep the bottom card link fixed a the bottom of the card
• 🅱️ include some left margin (ml-4) on the license status icon for better visual balance. (being addressed in Change icon spacing in license page #9823)

[mrsimonemms]

It's my understanding that there will always be a license, it's just that it may not be a license that the user has uploaded. It may be the "default license" (<= 10 users) or the "fallback license" (> 10 users)

If you're on the default license, it'll look similar to as it does in the screenshot. If it's the fallback, it'll only show the admin dashboard as an available feature and also show unlimited users.

[gtsiolis]

It's my understanding that there will always be a license

@mrsimonemms From what I understand, this is not the case for Gitpod.io, no?

Should we at least catch these edge cases and show something like Uknown License? I remember seeing this being added in https://github.com/gitpod-io/gitpod/pull/9343/files#diff-e1d7e44897170d01d2c3ace2ca628317d5ff39129f1b945b29381cad48a50670R128. Cc @nandajavarma

[nandajavarma]

Just to add to the discussion, in the case of gitpod.io and gitpod-staging.io, I am deliberately avoiding to set the value of the licenseType https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/admin/License.tsx#L27
I am currently of the opinion that this can be removed. Especially since is a rather light operation on the server. At the time of adding the change, I was trying to mimic what was done in the PR that added the settings page.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.