[Self-hosted]: cannot search users/workspaces without enterprise license and error is console only

[mrsimonemms]

Bug description

When I go to /admin/users in my self-hosted instance and click "search", I'm not able to search without an enterprise license. Whilst this is fine, the error only appears in the console.

It would be nice to have the error in the actual dashboard - an alert-style error

Steps to reproduce

Install self-hosted, go to admin and click "search"

Workspace affected

No response

Expected behavior

Should display the "enterprise license required" in the dashboard, not just the console

Example repository

No response

Anything else?

No response

[JanKoehnlein]

@jldec Shouldn't we rather disable the admin routes for non enterprise installs?

[jldec]

Either way works - a visible nudge can help to make users aware that they need a license :)

Silent browser console errors should be treated more like bugs. It would be helpful from an operations perspective if we had a way to collect those, just like server-side logs.

[laushinka]

Initially I would go for removing the Admin tab from non-enterprise users, but a visible nudge also makes sense.
How about showing a disabled Admin tab with a locked icon, and a tooltip saying that it's only for Professional users? Probably there are better ideas, but something along this line?

[jankeromnes]

Suggestion: The visible nudge to indicate that a license is required could be done like so:

1. Catch enterprise license required errors in Admin pages

2. Add export in front of the LimitReachedModal:

gitpod/components/dashboard/src/start/CreateWorkspace.tsx

Lines 212 to 227 in 7ccac75

	function LimitReachedModal(p: { children: React.ReactNode }) {
	const { user } = useContext(UserContext);
	return <Modal visible={true} closeable={false} onClose={() => { }}>
	<h3 className="flex">
	<span className="flex-grow">Limit Reached</span>
	<img className="rounded-full w-8 h-8" src={user?.avatarUrl || ''} alt={user?.name || 'Anonymous'} />
	</h3>
	<div className="border-t border-b border-gray-200 dark:border-gray-800 mt-4 -mx-6 px-6 py-2">
	{p.children}
	</div>
	<div className="flex justify-end mt-6">
	<a href={gitpodHostUrl.asDashboard().toString()}><button className="secondary">Go to Dashboard</button></a>
	<a href={gitpodHostUrl.with({ pathname: 'plans' }).toString()} className="ml-2"><button>Upgrade</button></a>
	</div>
	</Modal>;
	}

3. Import, customize (text and call-to-action), and show this modal -- will look something like this:

Source

[jldec]

Note discussion in #8328

could render this issue moot:

I would suggest that the admin dashboard is enabled for all license levels. This will allow us to put useful things in here in future

Even if we do keep limiting the use of the admin dashboard, the check should allow evaluation use when there are < 10 users.

[mrsimonemms]

As part of #8593, I've made the admin dashboard available to all licence levels. Once accepted, I think that solves this ticket