Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to drop some Gitpod layer metadata #1871

Closed
RDIL opened this issue Sep 17, 2020 · 6 comments
Closed

Add option to drop some Gitpod layer metadata #1871

RDIL opened this issue Sep 17, 2020 · 6 comments
Labels
feature: workspace image build meta: stale This issue/PR is stale and will be closed soon

Comments

@RDIL
Copy link

RDIL commented Sep 17, 2020

When building workspace images, Gitpod does this dumb process of modifying the bashrc file to add some configuration which doesn't need to exist assuming the image already does it.

If you want a more comprehensive idea on why this is extremely flawed, please see #1555.

My proposed solution

Add an empty file to all images that are meant explicitly for gitpod, like /bin/.is-gp-image.metadata, and if this file exists, then only add the declaration of user-set environment variable in Gitpod settings, and nothing else, assuming the image has the rest pre-configured, but if the file does not exist, add all the existing bashrc changes.
If a file doesn't work, maybe then just a list of image names that exclusively want to opt-out of this metadata addition.

Any thoughts @jankeromnes ?

I feel like this should be simple enough to implement.

@sr229
Copy link

sr229 commented Sep 19, 2020

We could use LABELs and parse them to automatically configure the container post-pull since this would allow us to use standard container features that are already builtin.

@RDIL
Copy link
Author

RDIL commented Mar 9, 2021

Any updates on this? Its still super annoying.

@stale
Copy link

stale bot commented Jun 7, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 7, 2021
@RDIL
Copy link
Author

RDIL commented Jun 7, 2021

Still really want this.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jun 7, 2021
@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 6, 2021
@stale stale bot closed this as completed Sep 16, 2021
@jankeromnes
Copy link
Contributor

FYI, the problematic Gitpod layer has been entirely removed in #4923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: workspace image build meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Development

No branches or pull requests

4 participants