Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codeql-version to outputs #2368

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Add codeql-version to outputs #2368

merged 4 commits into from
Jul 12, 2024

Conversation

mschwager
Copy link
Contributor

@mschwager mschwager commented Jul 10, 2024 •
edited
Loading

Fixes #2367.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Regarding the CHANGELOG check above, my understanding was that this would be automatically populated on release?

@mschwager mschwager requested a review from a team as a code owner July 10, 2024 16:02
@aeisenberg aeisenberg changed the title Fix #2367, add codeql-version to outputs Add codeql-version to outputs Jul 10, 2024
@aeisenberg
Copy link
Contributor

Thanks for your PR! The changelog note for this PR needs to be added manually. The automation for the changelog is around adding the release version number and the date.

@mschwager
Copy link
Contributor Author

Thanks for your PR! The changelog note for this PR needs to be added manually. The automation for the changelog is around adding the release version number and the date.

Done!

aeisenberg
aeisenberg reviewed Jul 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
aeisenberg
aeisenberg previously approved these changes Jul 10, 2024
View reviewed changes
@mschwager
Copy link
Contributor Author

Hey @ginsbach or @aeisenberg, would you mind approving the CI workflows to unblock merging?

@mschwager mschwager requested a review from aeisenberg July 12, 2024 15:22
@mschwager
Copy link
Contributor Author

Looks like it needs re-approval after the merge too

@aeisenberg
Copy link
Contributor

Thanks for the reminder. And thanks for your contribution!

@aeisenberg aeisenberg merged commit 09653b7 into github:main Jul 12, 2024
310 checks passed
@henrymercer henrymercer mentioned this pull request Jul 12, 2024
Merged
3 tasks
@mschwager mschwager deleted the add-codeql-version branch July 12, 2024 17:32
@mschwager
Copy link
Contributor Author

Sure thing, thanks for the speedy reviews!

This was referenced Jul 18, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CodeQL version to github/codeql-action/init outputs
2 participants
@mschwager @aeisenberg