-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for CodeQL v2.11.5 and earlier #2009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop testing `stable-20220908` bundle as this is no longer supported.
We'll need to update the set of required checks before merging this, since this PR stops testing CodeQL v2.10.5. |
angelapwen
previously approved these changes
Nov 27, 2023
CHANGELOG.md
Outdated
@@ -4,7 +4,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th | |||
|
|||
## [UNRELEASED] | |||
|
|||
No user facing changes. | |||
- The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.22.7. [#2009](https://github.com/github/codeql-action/pull/2009) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
angelapwen
previously approved these changes
Nov 27, 2023
The deprecation date was changed to 2023-12-20, so we need to hold off merging this until then. |
angelapwen
approved these changes
Jan 2, 2024
New deprecation date is 2024-01-04. |
8 tasks
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for CodeQL v2.11.5 and earlier, as announced in CodeQL Action v2.22.7.
I think it makes sense to remove support for CLI config parsing in a separate PR to simplify review and due to this being a higher risk code change.
Merge / deployment checklist