Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog note for CodeQL v2.10.5 deprecation #1993

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add changelog note for CodeQL v2.10.5 deprecation #1993

merged 2 commits into from
Nov 15, 2023

Conversation

henrymercer
Copy link
Contributor

I should follow my own instructions! :)

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner November 15, 2023 19:55
aeisenberg
aeisenberg reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@henrymercer
Copy link
Contributor Author

@aeisenberg Did you mean to approve?

aeisenberg
aeisenberg reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did mean to approve, but I'm now seeing two one very minor issues.

CHANGELOG.md Outdated Show resolved Hide resolved
@aeisenberg aeisenberg disabled auto-merge November 15, 2023 20:20
@aeisenberg aeisenberg enabled auto-merge November 15, 2023 20:23
@aeisenberg aeisenberg merged commit 0d0a53c into main Nov 15, 2023
337 checks passed
@aeisenberg aeisenberg deleted the henrymercer/deprecation-changenote branch November 15, 2023 20:51
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg