-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the sarif schema file #1668
Conversation
The version we were using is quite old. Copied the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json I do not think the sarif spec will be changing any more without an explicit version update, so this is fine for now.
9cd82da
to
ece3cbc
Compare
Fixes bug in `uniqueItems` property.
Oh...that's interesting. The failing check is also failing on main. https://github.com/github/codeql-action/actions/runs/4866066524/jobs/8677165330#step:5:77 There must be some update to the python yaml library we're using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of minor suggestions. Thanks for catching this.
Co-authored-by: Aditya Sharad <[email protected]>
For reference, this change was made because of a bug in the older version of the sarif schema, as described here: #1230 (comment) |
The version we were using is quite old. Copied the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json
I do not think the sarif spec will be changing any more without an explicit version update, so this is fine for now.
Merge / deployment checklist