Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the sarif schema file #1668

Merged
merged 5 commits into from
May 5, 2023
Merged

Conversation

aeisenberg
Copy link
Contributor

The version we were using is quite old. Copied the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json

I do not think the sarif spec will be changing any more without an explicit version update, so this is fine for now.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The version we were using is quite old. Copied the latest from
https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json

I do not think the sarif spec will be changing any more without
an explicit version update, so this is fine for now.
@aeisenberg aeisenberg force-pushed the aeisenberg/update-sarif-schema branch from 9cd82da to ece3cbc Compare May 2, 2023 20:52
Fixes bug in `uniqueItems` property.
@aeisenberg
Copy link
Contributor Author

aeisenberg commented May 2, 2023

Oh...that's interesting. The failing check is also failing on main. https://github.com/github/codeql-action/actions/runs/4866066524/jobs/8677165330#step:5:77

There must be some update to the python yaml library we're using.

Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of minor suggestions. Thanks for catching this.

src/sarif-schema-2.1.0.json Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aditya Sharad <[email protected]>
@aeisenberg aeisenberg enabled auto-merge May 5, 2023 15:49
@aeisenberg aeisenberg merged commit 11fba50 into main May 5, 2023
@aeisenberg aeisenberg deleted the aeisenberg/update-sarif-schema branch May 5, 2023 16:14
@github-actions github-actions bot mentioned this pull request May 24, 2023
6 tasks
@aeisenberg
Copy link
Contributor Author

For reference, this change was made because of a bug in the older version of the sarif schema, as described here: #1230 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants