-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Go extraction reconciliation feature flag and CODEQL_EXTRACTOR_GO_BUILD_TRACING
for custom builds
#1322
Conversation
d65ed09
to
152e246
Compare
CODEQL_EXTRACTOR_GO_BUILD_TRACING
CODEQL_EXTRACTOR_GO_BUILD_TRACING
I think it would make sense to add a changelog note in the PR that removes the feature flag check similar to the one we used before starting rollout, saying that we have now rolled out this change. You could then mention the variable deprecation there too — it won't affect most users but the Actions changelog can be more detailed. |
👍 I'll make a note to do so in that PR |
CODEQL_EXTRACTOR_GO_BUILD_TRACING
CODEQL_EXTRACTOR_GO_BUILD_TRACING
789f7e6
to
f69b64d
Compare
21816d5
to
9011d12
Compare
8f1b8c1
to
4d4d91d
Compare
I ended up finding an error in the Debug Artifacts Upload PR check because of this change — I hadn't added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a couple of comments around the docs.
ad71fd4
to
9f7a92c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, subject to @AlonaHlobina's approval of the warning message.
Co-authored-by: Henry Mercer <[email protected]>
6ad286b
to
1fa94b4
Compare
…odeql-action into angelapwen/deprecate-go-env-var
Ok — I resolved some merge conflicts, made some fixes to PR checks that were failing due to the new Go build command being added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo the CHANGELOG.
Co-authored-by: Henry Mercer <[email protected]>
…odeql-action into angelapwen/deprecate-go-env-var
This PR removes the
CODEQL_EXTRACTOR_GO_BUILD_TRACING
from all tests as well as another unused environment variable,CODEQL_ACTION_RECONCILE_TRACING
. Users who previously hadCODEQL_EXTRACTOR_GO_BUILD_TRACING
set with custom Go builds will be shown a warning suggesting that they remove the environment variable as it no longer has effect.Additionally, this PR deprecates the use of the Go extraction reconciliation feature flag so that its functionality is always on (ie. Go will always be treated as a traced language). A separate PR removing the flag from dotcom will be merged after this PR.
Merge / deployment checklist