Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explorer: updated label for issues with status done #785

Merged
merged 1 commit into from
Apr 4, 2018
Merged

explorer: updated label for issues with status done #785

merged 1 commit into from
Apr 4, 2018

Conversation

thelostone-mc
Copy link
Member

Description

Fix for #783

screen shot 2018-04-04 at 4 19 45 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • js
Refers/Fixes

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #785 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   33.87%   33.87%           
=======================================
  Files         101      101           
  Lines        5712     5712           
  Branches      669      669           
=======================================
  Hits         1935     1935           
  Misses       3698     3698           
  Partials       79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97557b...697eeea. Read the comment docs.

@thelostone-mc
Copy link
Member Author

@PixelantDesign

mbeacom
mbeacom approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @PixelantDesign Are you good with these changes?

@mbeacom mbeacom requested a review from PixelantDesign April 4, 2018 14:40
@mbeacom mbeacom merged commit de00083 into gitcoinco:master Apr 4, 2018
@mbeacom mbeacom added needs review frontend This needs frontend expertise. and removed needs review labels Apr 4, 2018
@abitrolly abitrolly mentioned this pull request Apr 5, 2018
Closed
@thelostone-mc thelostone-mc deleted the explorer branch April 7, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

@PixelantDesign PixelantDesign PixelantDesign approved these changes

Assignees
No one assigned
Labels
frontend This needs frontend expertise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @PixelantDesign @mbeacom