Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 after logout at profile page #905

Closed
kziemianek opened this issue Apr 17, 2018 · 2 comments
Closed

404 after logout at profile page #905

kziemianek opened this issue Apr 17, 2018 · 2 comments

Comments

@kziemianek
Copy link
Contributor

Description

Type: Bug

After logging out user is redirected to same page, which might result in 404 page.

Expected Behavior

User should be redirected to home page ?
Also accessing https://gitcoin.co/profile/ without being authorized should result in 401 page, not 404.

Reproduction

Logout at profile page or access https://gitcoin.co/profile/ being not logged in.

@kziemianek kziemianek changed the title 404 after logout at profile page. 404 after logout at profile page Apr 17, 2018
@mkosowsk
Copy link

mkosowsk commented Apr 17, 2018

@kziemianek nice find! I wish there was a Bug Bounty program running right now, you'd be getting more ETH than Vitalik! 😂 👍

@mbeacom
Copy link
Contributor

mbeacom commented Apr 17, 2018

@kziemianek This was my bad. I didn't modify the way we handle fetching profile information via /profile - Originally, we required a username to follow profile or default to the current user and 404ing if they don't exist or they don't have a profile... not so much an unauthorized situation.

Pushing in a fix for this now to redirect to home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants