Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bounties Payment wallet Address on April 1 #8673

Closed
Kweiss opened this issue Mar 24, 2021 · 6 comments
Closed

Update Bounties Payment wallet Address on April 1 #8673

Kweiss opened this issue Mar 24, 2021 · 6 comments

Comments

@Kweiss
Copy link
Member

Kweiss commented Mar 24, 2021

Who

GPG

What

When we spin out, we will need to update the Eth Address that the Bounties payments are made to. We need to use this Eth address:
0x88c62f1695DD073B43dB16Df1559Fda841de38c6

Please confirm the wallet address when making the change with @Kweiss

Why

@thelostone-mc
Copy link
Member

thelostone-mc commented Mar 24, 2021

is it just for bounties @Kweiss?

right now we use
0x00De4B13153673BCAE2616b67bf822500d325Fc3

and we've got that address hardcoded for

  • gitcoin grant donations
  • avatar_builder

There are also other stuff which are related to payout like (which seems to use the same public address) :

  • tip payout address
  • grants payout address

@Kweiss
Copy link
Member Author

Kweiss commented Mar 24, 2021

  • Let's use that address for Bounties fees - 0x88c62f1695DD073B43dB16Df1559Fda841de38c6

  • This for Grants development fund (linked to the Grant - I can do this after the round closes) - 0xd08Fe0c97c80491C6ee696Ee8151bc6E57d1Bf1d

  • Avatar Builder, Tip Payout, Kudos donation (basically any misc. revenue) can all use - 0xAD278911Ad07534F921eD7D757b6c0e6730FCB16

@octavioamu
Copy link
Contributor

octavioamu commented Apr 1, 2021

Ok about changing the maintainer address, we need to be sure all the points that could be affected
Running CLRs seems to be a blocker as we need to payout first

  • Tips on TIS (indirect send)
  • Kudos on KIS (indirect send)
  • Fees when creating bounties ( I think will be ok as are done when creating a bounty)
  • Old bounties using bounties network contract (not sure if will affected by this)
  • Grant when this get deployed then we can change our grant address if not probably cron jobs for grants will not count that contributions on the activity
  • mini clrs ?
  • stats on joe_dominance_index seems are counting those for Kevin probably will mess with the stats data.

Another topic is having diff address for each of those diff things is something we need to check the code and see if something will fail, as some logic is on js side and other on django side.
Many of the address are env variables so probably also we need to check the instances keys and do the changes.
Im missing / wrong some point here ?

@frankchen07
Copy link
Contributor

having a different address for each

Are you asking if it's not recommended to have a different address for each, or you just have to check to make sure that implementing these changes won't cause something to fail down the line?

old bounties

Do we have an idea of how many of these bounties still exist? Perhaps it's time to begin asking folks to close / cancel the bounties.

mini-clr

How do we feel about deprecated mini-clr or turning it off for now, now that Townsquare is also being hidden in new nav and homepage work?

@Kweiss
Copy link
Member Author

Kweiss commented Jun 16, 2021

The Grants checkout correctly displays the marking pool as the donation source. The backend no longer seems to be funding the correct Eth address though.

Screen Shot 2021-06-16 at 12 00 46 PM

This should go to: 0xde21F729137C5Af1b01d73aF1dC21eFfa2B8a0d6

These are currently going to: 0xd08Fe0c97c80491C6ee696Ee8151bc6E57d1Bf1d

@octavioamu
Copy link
Contributor

@Kweiss 320f9d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants