Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading button "Accept/reject claim" for non founder of the issue #81

Closed
ernaneluis opened this issue Dec 4, 2017 · 8 comments
Closed
Labels
easy-pickings This is an easy issue for the community.

Comments

@ernaneluis
Copy link
Contributor

After claim to a issue and later check the issue page. The website shows a button "accept/reject" issue. However, is not the owner of the issue. Besides, if you click the button, it shows tabs for creating a issue, which is meant for the founder of the issue to accept or reject the claim.

screen shot 2017-12-04 at 21 06 21

screen shot 2017-12-04 at 21 06 28

@owocki
Copy link
Contributor

owocki commented Dec 4, 2017

more generally, i feel strongly that the funded issue detail page should only present to users actions that are enabled for them specifically

@ernaneluis
Copy link
Contributor Author

Yes I agree with you.

@owocki
Copy link
Contributor

owocki commented Dec 12, 2017

posting a bounty for this. requirements

  • no button shall appear under the 'funding amount: xxx ETH yyy USD' area unless it is actoinable be the user
  • includes but this is not an exhaustive list:
  • clawback funds
  • accept/reject
  • claim issue
    etc

this is where the buttons are generated on the JS https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/bounty_details.js#L317-L376

@tra38
Copy link
Contributor

tra38 commented Dec 12, 2017

I would like to take this bounty once it gets posted live, @owocki.

@owocki owocki added the easy-pickings This is an easy issue for the community. label Dec 12, 2017
@owocki
Copy link
Contributor

owocki commented Dec 12, 2017

@tra38 am waiting for this issue to be turned around MetaMask/metamask-extension#2736 -- the service relies upon metamask/infura, so i can't reliably post a bounty until thats fixed.

you can go ahead and get started @tra38 -- i will just tip you directly when its done. how does 0.05 ETH sound? can you submit a PR back to the repo in some reasonable amount of time, say the next 3 days?

@tra38
Copy link
Contributor

tra38 commented Dec 12, 2017

0.05 ETH sounds good to me. 3 days sounds like a reasonable deadline as well.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.06 ETH ($41.03) has been granted to @tra38 for this issue. ⚡️

The sender had the following public comments:

this is a good fix for the ui of bounty details page!

Nice work @tra38, check your email for further instructions.

@owocki owocki closed this as completed Dec 17, 2017
@gitcoinbot
Copy link
Member

The funding of 0.07 ETH (55.78 USD) attached to this issue has been approved & issued .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy-pickings This is an easy issue for the community.
Projects
None yet
Development

No branches or pull requests

4 participants