new_bounty marketing emails need to be moved to a background job

[owocki]

related commit: dd9f45e

the new_bounty functionality doesnt scale because there are typically a bunch of matches generated in this loop => https://github.com/gitcoinco/web/blob/master/app/dashboard/notifications.py#L416-L427

please move this code into a background job. two ways we could go:

1. invest in a true event driven procescesing system (like celery, or a log based microservices architeture)
2. just do it in a management command

[gitcoinbot]

This issue now has a funding of 0.03 ETH (25.67 USD) attached to it.

• If you would like to work on this issue you can claim it here.
• If you've completed this issue and want to claim the bounty you can do so here
• Questions? Get help on the Gitcoin Slack
• $10202.54 more Funded OSS Work Available at: https://gitcoin.co/explorer

[vs77bb]

@g33klord 👋 which route are you thinking on this one?

[g33klord]

@vs77bb Hi! I am planning to do it using celery. Setting up celery will be beneficial for other part of projects too.

[owocki]

neat-o. @g33klord id love to see some basic celery setup instructions included with your submission so we can implement in production the same way you did.

[mbeacom]

@g33klord Thanks for starting on this. If you need any assistance setting up Celery, please let me know. If possible, I'd like to limit our need for self-hosted services as much as possible (making use of managed services like SQS or elasticache-based Redis would be ideal for the broker), but I'm not opposed to self-hosted Rabbitmq... however, I'm trying to avoid adding more hosted solutions when possible. Ideally, the celery worker would be provisioned as a docker image for local development and live implementation.

[g33klord]

@mbeacom I understand. I am proceeding in direction to provision celery worker as a docker image.

[owocki]

@g33klord are you still working on this? im happy to throw a little more ETH in since the market has been upser bear recently

[mbeacom]

@g33klord If not, no sweat!

If it's simpler, maybe we could implement Celery first on our end first. Feel free to let us know what works best for you!

[mbeacom]

@g33klord We'll be merging in Celery integration either today or tomorrow via: #668

[AlekKras]

I am new to this issue, so I might be extremely wrong but could that be a solution?

from celery import Celery

app = Celery(
    # XXX The below 'myapp' is the name of this module, for generating
    # task names when executed as __main__.
    'myapp',
    broker='amqp://guest@localhost//',
    # ## add result backend here if needed.
    # backend='rpc'
)

app.conf.timezone = 'UTC'


@app.task
def maybe_market_tip_to_github(tip):
     tip = dashboard.models.Tip
     if (not settings.GITHUB_CLIENT_ID) or ( not tip.github_url) or (not settings.GITHUB_CLIENT_COMMENT):
         return False
 

@app.on_after_configure.connect
def setup_periodic_tasks(sender, **kwargs):
  
    sender.add_periodic_task(10.0, maybe_market_tip_to_github(tip))

if __name__ == '__main__':
    app.start()

[vs77bb]

@mbeacom I think question is in your court here...

@AlekKras Would you mind claiming work on Gitcoin here by clicking 'Start Work'? Probably removed on our end due to inactivity, apologies.

[mbeacom]

@vs77bb @AlekKras This is already implemented and tracked at #668

This issue will be a followup after the above is merged.

[gitcoinbot]

@AlekKras are you still working on this issue?

[gitcoinbot]

@AlekKras has been removed from this issue due to inactivity (12 days) on the github thread. @AlekKras if you believe this was done in error, please go to the bounty and click 'start work' again.

[gitcoinbot]

Work has been started on the 0.03 ETH (19.19 USD @ $639.52/ETH) funding by:

1. @gitcoinbot

Please work together and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@owocki) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

• Learn more on the gitcoin issue page
• Questions? Get help on the Gitcoin Slack
• $5384.22 more Funded OSS Work Available at: https://gitcoin.co/explorer

[mkosowsk]

@gitcoinbot finally getting in the game and programming! @mbeacom might want to take a look at this one :)

Also can't help but notice that @gitcoinbot is confused by programming... I can relate 😅

[owocki]

this was me testing.. whoops

[mkosowsk]

@owocki good to hear, means the bots haven't become sentient... yet 😳😳😳

[mbeacom]

That won't be a problem until we onboard Eklow Labs.

[gitcoinbot]

The funding of 0.03 ETH (19.19 USD @ $639.52/ETH) attached to this issue has been killed by the bounty submitter

• Questions? Get help on the Gitcoin Slack
• $5384.22 more Funded OSS Work Available at: https://gitcoin.co/explorer