Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

void #462

Closed
ghost opened this issue Feb 18, 2018 · 20 comments
Closed

void #462

ghost opened this issue Feb 18, 2018 · 20 comments
Assignees
Labels
bug This is something that isn't working as intended.

Comments

@ghost
Copy link

ghost commented Feb 18, 2018

No description provided.

@mbeacom mbeacom self-assigned this Feb 18, 2018
@mbeacom mbeacom added bug This is something that isn't working as intended. high-priority labels Feb 18, 2018
@zheli
Copy link

zheli commented Feb 18, 2018

@owocki
Copy link
Contributor

owocki commented Feb 18, 2018

Thanks for the report. We are debugging at ETHDenver now. / @mbeacom

@mbeacom
Copy link
Contributor

mbeacom commented Feb 18, 2018

@lazaridiscom Do you happen to have the tx for your submission?

@mbeacom mbeacom changed the title [CRITICAL] Bounty Resets after Submitting Work Bounty Resets after Submitting Work Feb 19, 2018
@mbeacom mbeacom changed the title Bounty Resets after Submitting Work Legacy Bounty resets after Submitting Work Feb 19, 2018
@ghost ghost changed the title Legacy Bounty resets after Submitting Work [CRITICAL] Legacy Bounty resets after Submitting Work Feb 20, 2018
@ghost ghost changed the title [CRITICAL] Legacy Bounty resets after Submitting Work [CRITICAL] Bounty resets after Submitting Work Feb 20, 2018
@mbeacom
Copy link
Contributor

mbeacom commented Feb 20, 2018

@lazaridiscom Legacy refers to bounties using the old processing logic and legacy gitcoin contract.

@zheli
Copy link

zheli commented Feb 21, 2018

@lazaridiscom I got my bounty on Monday so I can't try now :)

@owocki
Copy link
Contributor

owocki commented Feb 21, 2018

@lazaridiscom appreciate the issue filing here ! i am still working through my ETHDenver backlog, this is high on my triage list though

@vs77bb
Copy link
Contributor

vs77bb commented Feb 21, 2018

@lazaridiscom: @mbeacom pushed some frontend fixes that has triaged this issue. You should see your submission listed below. It's difficult to test this as it's from our legacy smart contracts (before integrating Standard Bounties), but he pushed a fix to a callback which hopefully will clean this up going forward. We'll continue to monitor closely and test a few other legacy issues as we can.

Let us know if you have any issues still with your submission!

https://gitcoin.co/legacy/funding/details?url=https://github.com/ethereum/web3.py/issues/549

@vs77bb vs77bb added in progress and removed to do labels Feb 22, 2018
@owocki
Copy link
Contributor

owocki commented Feb 22, 2018

thanks for handling this @mbeacom and the bug report @lazaridiscom

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH ($42.78) has been granted to @lazaridiscom for this issue from Kevin. ⚡️

The sender had the following public comments:

Thanks for your care & stewardship of this issue!

Nice work @lazaridiscom! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@owocki
Copy link
Contributor

owocki commented Feb 22, 2018

word; were tracking that over at #115

@owocki
Copy link
Contributor

owocki commented Feb 22, 2018

let me bounty that now actually

@owocki
Copy link
Contributor

owocki commented Feb 22, 2018

hehe; gitcoin isnt the only git-network with a bug here there ;)

@owocki
Copy link
Contributor

owocki commented Feb 26, 2018

Despite this issue having "work submitted" status, I got

Are you suggesting that the email notifier should not warn users who have started AND submitted work?

@owocki
Copy link
Contributor

owocki commented Feb 26, 2018

thx for the report! just put in a fix for this; 2f005f3

@owocki
Copy link
Contributor

owocki commented Feb 27, 2018

i put in a bunch of fixes for these issues over at #474 and tehre is a post mortem medium post coming tomorrow to acknowledge / reflect on the issues. lmk if you think its okay to close this issue

@ghost ghost closed this as completed Feb 27, 2018
@owocki
Copy link
Contributor

owocki commented Feb 27, 2018

=> "State-Machine, Draft" (super-important work, annoyingly difficult to produce)

is this what you were looking for? http://bits.owocki.com/1b372N34143l/Screen%20Shot%202018-02-27%20at%208.59.10%20AM.png

@owocki
Copy link
Contributor

owocki commented Feb 27, 2018

=> Conflict Resolution, Draft (its something that must be done sooner or later)

this is something that @mbeylin is working on and has put a TON of thought in... should be live in Q2 or after

@mkosowsk
Copy link

Haha

@lazaridiscom I recommend you use emoji in your messages 👍

I work with an international team and find it helps get the emotions across better, a friendly 😂🤣after a joke helps people get the message

Happy posting! 💪🏻🤠👍🏻

@mkosowsk
Copy link

http://journals.sagepub.com/doi/abs/10.1177/0894439307311611?journalCode=ssce

Overall, the authors conclude that to a large extent, emoticons serve the same functions as actual nonverbal behavior.

Would recommend you consider using emojis, they really can help remove message ambiguity over text based messaging 👍🏻

@mkosowsk
Copy link

Guess we'll have to agree to disagree! 👍

@ghost ghost changed the title [CRITICAL] Bounty resets after Submitting Work void Mar 8, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

No branches or pull requests

7 participants