Active subscription not listed under "active subscriptions"

[pascalvanhecke]

Describe the bug

user pascalvanhecke has active subscription (as indicated by interface in screenshot) but subscription is not listed as active. Also: the subscription has not been charged after 2 days.

Expected behavior
Subscription should have been charged (it was intended as a one-time donation), and should have been registered as a contribution

Additional context

The bug is probably related to an earlier reported bug #3762 and possibly has the same cause (failed and/or overridden cancellations being interpreted as actual cancellations)

[PixelantDesign]

Thanks for the report @pascalvanhecke! We'll get this prioritized asap!
cc @frankchen07

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.33 ETH (45.5 USD @ $137.89/ETH) attached to it as part of the gitcoinco fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $42,429.32 more funded OSS Work available on the Gitcoin Issue Explorer

[MatthewPChapdelaine]

Another step would be getting Docker installed for testing.

[MatthewPChapdelaine]

Docker installed.

[MatthewPChapdelaine]

https://user-images.githubusercontent.com/16426923/53675429-1ba97f80-3c64-11e9-8346-2301bd2eada4.jpg

[MatthewPChapdelaine]

[frankchen07]

@Razorblade16 - sounds good, looking forward to seeing your work!

[frankchen07]

hi @MatthewPChapdelaine , any progress here? if not, I will remove you from this bounty and release back to the public. If you decide you want to try again, feel free to start work again.

[frankchen07]

@MatthewPChapdelaine - I'm going to remove you from this bounty since you've been non-responsive. If you come back and the bounty is still open, feel free to reach out and communicate on any progress.

[frankchen07]

@speedyFixer - sounds good! The issue includes fixing the bug.

[speedyFixer]

@frankchen07 Perfect! @gitcoinbot as I wrote, I going to start tomorrow.

[speedyFixer]

@frankchen07 @gitcoinbot right now working on this!

Updated Plan status:

• Prepare a local environment for debugging
• Reading the repository
• Localization of subscription related code
• Load grant data in local test environment
• Describe a group of steps for reproduce the bug Working in this item
• Fix the bug
• Test the solution

[speedyFixer]

Status Update:

I found some times num_tx_approved is missing in POST request and the default value assigned to It is an int:

web/app/grants/views.py

Line 427 in 9ea8fbe

subscription.num_tx_approved = request.POST.get('num_tx_approved', 1)

Therefore, in the following condition the result will be False:

web/app/grants/views.py

Line 434 in 9ea8fbe

if subscription.num_tx_approved == '1':

That behavior will create an Inactive subscription, please check the image:

Right records of contributions are with the code fix and inactive subscriptions is with the bug.

• What is the cause of the num_tx_approved be missing in the POST request?
  Seems something with MetaMask in the JS code. (I'm not sure about It)

[owocki]

hmm that post should not happen without num_tx_approved in the POST..

[speedyFixer]

Yes I'm aware of that, I'm looking deeper for the cause of missing num_tx_approved or check if I found another reason.

[speedyFixer]

@owocki, @frankchen07, @PixelantDesign Are there more reports of users experiment this issue?

[frankchen07]

I have not - @ceresstation - have you?

[speedyFixer]

Hi @ceresstation , any update?

[speedyFixer]

I'm going to stop in Gitcoin while I wait for more info for fix this issue.

[frankchen07]

closing this out until the bug resurfaces again

[gitcoinbot]

⚡️ A tip worth 0.06000 ETH (14.63 USD @ $243.78/ETH) has been granted to @speedyFixer for this issue from @frankchen07. ⚡️

Nice work @speedyFixer! Your tip has automatically been deposited in the ETH address we have on file.

• $79804.48 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack