Kevins Grants QA 20181120

[owocki]

• hover animation doesnt exist for grants logo (screencast: http://bits.owocki.com/fd6f3949ae6f/Screen%20Recording%202018-11-20%20at%2010.49%20AM.gif )

Fund page

• 'please unlock metamask to continue' doesnt work with EIP 1102
  ( screenshot http://bits.owocki.com/ac9f6e29a840/Screen%20Shot%202018-11-20%20at%2010.47.05%20AM.png )
  we'll need to integrate the 'connect to metamask' button that exists elsewhere on the app.
• Lorem ipsum needs removed http://bits.owocki.com/c95e1b789d9a/Screen%20Shot%202018-11-20%20at%2011.06.40%20AM.png
• There still too much cognitive overhead to the "Value Of Payment Per Period" form element. Can we change "Value Of Payment Per Period" to "Tokens Per Period"
• There still too much cognitive overhead to the "token approval limit" form element. Can we change "Token Approval Limit" to be a select box with the options "1 period", "2 periods", "3 periods" up to 25 periods. There should also be a "No Limit" option that sets the limit to be 9999999999999999999999999999.
• This link goes to the external URL, not to the actual grant URL
• ETH is in the dropdown everywhere, but ETH isnt supported (WETH is) per @thelostone-mc comment here SHOWSTOPPER

Grant Detail page

• This grant has no Team members. Should we allow a grant with no team members? My gut says no.. At the very least, the pereson who posted the grant should be on the team.

Create grant page

• Results could not be loaded on 'team members' input. I assume this is GH API rate limit issue?

Loading page

• Why is my 'external URL' shown on the loading page? screenshot
• integrity error upon insert screenshot - SHOWSTOPPER

Edit Grant Page

• What is this module and why does it not have a label on it?
• "Post Update" button doesnt work.. No updates are posted.
• Updates are all still lorem ipsum - SHOWSTOPPER

Create Milestone

• No way to get back to the main grant page from the 'create milestone' page.

Grant Details Page

• can we add a SLUG to the grant URL? https://grants.gitcoin.co/grants/8 coudl become https://grants.gitcoin.co/grants/8/foo-bar

[mbeacom]

• hover animation doesnt exist for grants logo (screencast: http://bits.owocki.com/fd6f3949ae6f/Screen%20Recording%202018-11-20%20at%2010.49%20AM.gif )

This will be resolved once we resolve file conflicts/rebase.

• Lorem ipsum needs removed http://bits.owocki.com/c95e1b789d9a/Screen%20Shot%202018-11-20%20at%2011.06.40%20AM.png

This was set by @willsputra - Grant.description

• This grant has no Team members. Should we allow a grant with no team members? My gut says no.. At the very least, the pereson who posted the grant should be on the team.

Agreed. I'll update it to automatically add the admin to the team list.

• Results could not be loaded on 'team members' input. I assume this is GH API rate limit issue?

Yes. Fixing it now.

• This link goes to the external URL, not to the actual grant URL

This link directs to the Grant.reference_url that was provided during the creation process.
This grant has http://github.com/ provided as the reference URL.

Do you think it'd be helpful to link back to gitcoin grant details versus the external url or omit it entirely?

• integrity error upon insert screenshot - SHOWSTOPPER

I'll look into this shortly! Should be a simple fix.

• can we add a SLUG to the grant URL? https://grants.gitcoin.co/grants/8 coudl become https://grants.gitcoin.co/grants/8/foo-bar

🙌 Sounds good.

[owocki]

This was set by @willsputra - Grant.description

oh so it's not dynamic? nice!

I'll look into this shortly! Should be a simple fix.

let me know how this goes so i can continue QA :)

[thelostone-mc]

Open issues are captured here #2949