Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ERC-1337 Landing Page #2116

Closed
8 tasks done
PixelantDesign opened this issue Aug 28, 2018 · 23 comments
Closed
8 tasks done

Build ERC-1337 Landing Page #2116

PixelantDesign opened this issue Aug 28, 2018 · 23 comments
Assignees

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Aug 28, 2018

User Story

As a user I would like to understand what ERC-1337 is about and who is behind this project.

Definition of Done

  • Build the landing page in HTML & CSS as designed
  • Animation is a plus, but not a requirement
  • Use DIN Font
  • Add photos of the team on Team members section
  • Assets should be optimized
  • The page should be responsive
  • Test the page in major browsers
  • Review with @pixelandesign @owocki @thelostone-mc

Additional Information

  • This is an approval required bounty with a 14 Day Turnaround.
  • File cannot be uploaded to Github due to size. Please message me if you are the approved worker.

eip1337 am

@thelostone-mc
Copy link
Member

thelostone-mc commented Aug 29, 2018

@PixelantDesign Added in my name to help review ^_^

@owocki Any preference on the tech stack which is to be used to build this out ?
It is just a static page

@owocki

This comment has been minimized.

@owocki
Copy link
Contributor

owocki commented Aug 29, 2018

@owocki Any preference on the tech stack which is to be used to build this out ?

i think static html would be easiest.. dont see the need to overcompliace this!

@thelostone-mc

This comment has been minimized.

@owocki
Copy link
Contributor

owocki commented Aug 29, 2018

a month from now

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.45 ETH (128.58 USD @ $285.74/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Aug 30, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 weeks, 3 days from now.
Please review their action plans below:

  1. Manjilan has been approved to start work.

    Get the assets from the bounty poster.
    Code HTML and CSS.
    Create the Desktop Version and add media queries to make it Mobile Responsive.
    Add animations for any actions.
    Cross Platform and Cross Browser testing.

Learn more on the Gitcoin Issue Details page.

  1. aj07 has applied to start work (Funders only: approve worker | reject worker).

    I want to work on this. Please share the repo where I should upload the file or I should do it in my repo and share the link.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link
Member

@Manjilan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Manjilan
Copy link

Manjilan commented Sep 2, 2018

I am done with the HTML and some of the CSS. Will be done with it on Tuesday and check if any changes are required.

@thelostone-mc
Copy link
Member

@Manjilan looking forward to it :D

@PixelantDesign
Copy link
Contributor Author

Looking forward to seeing this @Manjilan!

@Manjilan
Copy link

Manjilan commented Sep 3, 2018

  • Build the landing page in HTML & CSS as designed
  • Animation is a plus, but not a requirement
  • Use DIN Font
  • Add photos of the team on Team members section
  • Assets should be optimized
  • The page should be responsive
  • Test the page in major browsers
  • Review with @pixelandesign @owocki @thelostone-mc

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.45 ETH (128.67 USD @ $285.94/ETH) has been submitted by:

  1. @Manjilan

@PixelantDesign please take a look at the submitted work:


@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 5, 2018

  • The main banner has whitespace which needs to be removed as shown here
  • The icons seem to be a lil pixelated. Would it make sense to use svgs instead ?
  • The footer Get Involved section breaks when I decrease the screen size
  • This section seems cramped on mobile
  • Reduce padding here

@PixelantDesign @owocki The site is up on github pages here

x

@Manjilan
Copy link

Manjilan commented Sep 5, 2018

@thelostone-mc Thank you for the review. I will work on it and fix these issues.

@gitcoinco gitcoinco deleted a comment from aarondr77 Sep 5, 2018
@Manjilan
Copy link

The final product is on github repo https://github.com/Manjilan/EIP1337 and just to check it is hosted on github pages at https://manjilan.github.io/EIP1337/ . Please let me know if anything else needs to be done.

@thelostone-mc
Copy link
Member

except the extra authors ! Everything else LGTM ^_^

@Manjilan
Copy link

Manjilan commented Sep 11, 2018

I have added the new team member info as well. Now we don't have any filler pictures and info.

@thelostone-mc
Copy link
Member

As discussed offline with @PixelantDesign and @Manjilan looks like we can wrap this up
For now I've moved the code over to https://github.com/gitcoinco/ERC-1337/
and it's live at https://gitcoinco.github.io/ERC-1337/

@owocki @PixelantDesign @Manjilan

@PixelantDesign
Copy link
Contributor Author

Thanks! @thelostone-mc
Thanks for the quick turn around @Manjilan !

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.06750 ETH (12.29 USD @ $182.03/ETH) has been granted to @Manjilan for this issue from @PixelantDesign. ⚡️

Nice work @Manjilan! Your tip has automatically been deposited in the ETH address we have on file.

@owocki
Copy link
Contributor

owocki commented Sep 11, 2018

@PixelantDesign good to payout!?

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.45 ETH (81.96 USD @ $182.13/ETH) attached to this issue has been approved & issued to @Manjilan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants