Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better State Management: "No result found" and "Results" are getting displayed at the same time #1938

Closed
Rahul-Sagore opened this issue Aug 4, 2018 · 1 comment
Assignees
Labels
bug This is something that isn't working as intended. frontend This needs frontend expertise.

Comments

@Rahul-Sagore
Copy link

Describe the bug
Need to handle state in better way. If I randomly clicks on sidebar Radio button, without waiting for response then result of two API call gets displayed on page.
E.g if one radio button has no result for API call and second one had results, then I was able to see both things at same time:

To Reproduce

  • Click "Fullfilled by me" under "My Projects", it will render "No result found"
  • Click on "Any" will render results.
  • If you click "Any", and if you click "Fullfilled by me" before "Any" gets any response, then it will render both "No result found" + Results from "Any".

Expected behavior
Need to Abort previous API call, only the latest API Call's result should be visible not the previous ones.

Screenshots
screen shot 2018-08-04 at 2 44 37 pm

Desktop (please complete the following information):

  • OS: MAC OS X : 10.11.2
  • Browser: Chrome
  • Browser Version 67

Additional context
ScreenCast:
https://drive.google.com/file/d/1ms3XlDWWeLTLV_tvceNWonUEdThpnHZ-/view?usp=sharing

@thelostone-mc
Copy link
Member

@Rahul-Sagore thanks for pointing that out ^_^

@thelostone-mc thelostone-mc added bug This is something that isn't working as intended. frontend This needs frontend expertise. and removed in progress labels Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended. frontend This needs frontend expertise.
Projects
None yet
Development

No branches or pull requests

3 participants