Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Grants Withdrawal" Page - Design #1907

Closed
6 of 7 tasks
captnseagraves opened this issue Aug 1, 2018 · 10 comments
Closed
6 of 7 tasks

Create "Grants Withdrawal" Page - Design #1907

captnseagraves opened this issue Aug 1, 2018 · 10 comments
Assignees

Comments

@captnseagraves
Copy link
Contributor

captnseagraves commented Aug 1, 2018

User Story

As a Grant creator, I want to withdraw funds that have been given to the project on a monthly basis so that I can sustain myself and my team

Why Is this Needed

The "Grants Withdrawal" page is needed to allow a grant creator to withdrawal funds that have been given to the project

Description

Type: Feature

Definition of Done

  • Page displays the total funding the grant has received
  • Page displays the next date/time funds can be withdrawn
  • Page displays the current withdrawable amount
  • Page has a "Withdraw Funds" button
  • Page displays a Withdrawal History of previous withdrawal activity in the grant
  • Page has standard Gitcoin header and footer
  • Design must be on brand, see creative repo for brand guide

Additional Information

To be reviewed with @PixelantDesign @mbeacom @captnseagraves

Existing assets can be found at this PR: #674
More information about the Dev Grants project can be found here: #1469

Please allow the core team a few rounds of revisions.

@captnseagraves
Copy link
Contributor Author

Assigning @justpixel

@justpixel
Copy link

Do you think a modal window is enough? Or it should have a separate page?
withdraw funds

@captnseagraves
Copy link
Contributor Author

@justpixel As addressed on the team call this morning, it probably makes more sense for this view to be a page instead of a modal. Could you iterate on this idea, please?

I would also like to see, assuming I am still within a given period, when the next date/time I will be able to make a withdrawal is. Text could read "Next Withdrawl: date/time". If there is a withdrawable amount text should read "Now". I will update the original issue with these checkboxes.

@owocki
Copy link
Contributor

owocki commented Aug 8, 2018

i think we decided this should be a page not a modal right?

other than that LGTM

@PixelantDesign
Copy link
Contributor

yes looks good! let's put on a page.

What happens after I click withdraw? Metamask?

@justpixel
Copy link

withdraw funds

@PixelantDesign
Copy link
Contributor

Looks good to me.

@captnseagraves should we also display USD value under ETH?

@justpixel
Copy link

Design:
withdraw funds

@captnseagraves
Copy link
Contributor Author

Yes, I think having USD displayed would be nice! Could you add that to the design @justpixel ?

@captnseagraves
Copy link
Contributor Author

Closing this issue. I like the designs though and will reference them in the new "transaction summary" ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants