Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Allow Funder to Manage Auto Approvals #1807

Closed
5 tasks
PixelantDesign opened this issue Jul 21, 2018 · 11 comments
Closed
5 tasks

BUILD: Allow Funder to Manage Auto Approvals #1807

PixelantDesign opened this issue Jul 21, 2018 · 11 comments

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Jul 21, 2018

User Story

As a funder whois using work by approval, I'd like to manage Auto approval of start work on approval only bounties. This way users do not get auto approved after 72 hours.

Why Is this Needed

Summary: Currently no way to do this.

Description

Type: Feature

Solution

Ideas:

  • On Bounty Funder Form --If a project type is set to approval, show a progressive disclosure that allows the funder to turn off auto approve.
  • Use a checkbox to toggle setting/off and on
  • Display on the issue details as well, so that contributors know that they will not be auto approved after 72 hrs.

Open to other ideas.

Definition of Done

  • A setting is added so that funders can manage or turn off auto approval after 72 hours.
  • This features is built and tested.

Additional Information

Review with @PixelantDesign @owocki

@PixelantDesign PixelantDesign added this to the August 2018 milestone Jul 21, 2018
@owocki
Copy link
Contributor

owocki commented Jul 23, 2018

This way users do not get auto approved after 24 hours.

the auto approve timeline is currently set to be 72 hours, not 24.

@owocki
Copy link
Contributor

owocki commented Jul 23, 2018

@PixelantDesign should we bounty this? seems like it should not be that hard of a lift

@PixelantDesign PixelantDesign changed the title Allow Funder to Manage Auto Approvals BUILD: Allow Funder to Manage Auto Approvals Jul 31, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.139 ETH (62.87 USD @ $452.3/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jul 31, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 months, 3 weeks from now.
Please review their action plans below:

  1. darkdarkdragon has been approved to start work.

    Questions in dm. Will start and make it done :).
    It's annoying.

Learn more on the Gitcoin Issue Details page.

@PixelantDesign
Copy link
Contributor Author

PixelantDesign commented Jul 31, 2018

Note: To avoid scope creep, we will add toggling change after the fact and displaying in activity feed on a separate ticket.

Here

@PixelantDesign PixelantDesign modified the milestones: August 2018, August 2018 Bountied Tasks Jul 31, 2018
@gitcoinbot
Copy link
Member

@darkdarkdragon Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@darkdarkdragon
Copy link
Contributor

@gitcoinbot still working

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.139 ETH (57.26 USD @ $411.91/ETH) has been submitted by:

  1. @darkdarkdragon

@PixelantDesign please take a look at the submitted work:


@rmshea
Copy link
Contributor

rmshea commented Sep 26, 2018

Hey @PixelantDesign, have you had a chance to check @darkdarkdragon's PR? :)

@PixelantDesign
Copy link
Contributor Author

PixelantDesign commented Sep 27, 2018

@ryan-shea according to this PR #1945
there are conflicts to be resolved.

@PixelantDesign PixelantDesign removed this from the August 2018 Bountied Tasks milestone Nov 8, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.139 ETH (29.51 USD @ $212.34/ETH) attached to this issue has been approved & issued to @darkdarkdragon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants