Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Cancelled Bounties Latest Activity in Profile #1770

Closed
5 tasks
PixelantDesign opened this issue Jul 17, 2018 · 9 comments
Closed
5 tasks

Show Cancelled Bounties Latest Activity in Profile #1770

PixelantDesign opened this issue Jul 17, 2018 · 9 comments
Labels
good first issue This a good first issue for a community newcomer. help wanted

Comments

@PixelantDesign
Copy link
Contributor

User Story

Why Is this Needed

Summary: Not shown now

Description

Type: Feature

Current Behavior

Not shown in profile

Expected Behavior

Show in profile

Definition of Done

  • Update Funded Bounties Module to be Bounties
  • On the bounties tab add a filter using a drop down to show Cancelled Bounties (upper right)
  • Test the functionality
  • Link a PR to this ticket
  • Review with a Gitcoin core tam member
@PixelantDesign PixelantDesign added help wanted good first issue This a good first issue for a community newcomer. labels Jul 17, 2018
@chiptus
Copy link

chiptus commented Sep 4, 2018

Can I start with this issue?

@chiptus
Copy link

chiptus commented Sep 4, 2018

Would love to get some pointers on where to look (my first issue).
Will this be mostly changing the template, or also the profile endpoint? or class?

And how can I test this on my machine? I have the env running, I probably should enable the login (by adding the right values for a github app in the .env file, right?)

Can I make a fake profile with cancelled bounties and other types of bounties so I can see a full list on the profile page?

@owocki
Copy link
Contributor

owocki commented Sep 4, 2018

checkout the docs to see how to create an account / run on your local machine => https://github.com/gitcoinco/web/tree/master/docs

Will this be mostly changing the template, or also the profile endpoint? or class?

could be both, i think you're asking the right questions :)

@PixelantDesign
Copy link
Contributor Author

@SaptakS are you handling this in the profile rework?

@chiptus
Copy link

chiptus commented Sep 26, 2018

I'm not sure if I should continue (actually start, since I haven't done nothing but start the env)
I'm still trying to understand your codebase.
I see on profile.html that there are three sections - in-progress, funded, and completed.
Do you mean that we should have one section with ability to choose the right type of bounty? in-progress/funded/completed/cancelled?

@PixelantDesign
Copy link
Contributor Author

@SaptakS was this part of tge recent profile work?

@PixelantDesign
Copy link
Contributor Author

@chiptus we have some other work if you’re interested!

@SaptakS
Copy link
Contributor

SaptakS commented Sep 27, 2018

@PixelantDesign Yes. This is already handled here

@PixelantDesign
Copy link
Contributor Author

thanks! closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This a good first issue for a community newcomer. help wanted
Projects
None yet
Development

No branches or pull requests

4 participants