Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Toggle - Clear Comments on Github Issue #1465

Closed
PixelantDesign opened this issue Jun 14, 2018 · 7 comments
Closed

Admin Toggle - Clear Comments on Github Issue #1465

PixelantDesign opened this issue Jun 14, 2018 · 7 comments
Assignees

Comments

@PixelantDesign
Copy link
Contributor

User Story

As an admin I'd like the ability to clear comments from a Github issue.

Why Is this Needed?

Summary:

Currently when multiple users start and stop an issue it create alot of activty on the github thread but no real progress on the issue.

Solution

Summary:

Add ability to clear comments on a Github issue from issue details page in preparation for re-marketing.

The solution should not erase the original issue description that is posted on the Github ticket.

@owocki
Copy link
Contributor

owocki commented Jun 15, 2018

@PixelantDesign a few pieces of feedback:

  1. we will only be able to do this if the user making the request to the github API (probably either the authenticated user on gitcoin, or gitcoinbot itself) has permissions to delete comments on the github thread. so i think this will work in cases in which the person clearing the comments is the issue submitter or owner of the repo, but in cases in which those two things are no the case, this won't be possible from a permissions standpoint:

  2. i think we should backup the deleted content. maybe we could save it and store it into a github gist ?

  3. would it be cleaner to, instead of deleting all the comments, create a new, clean, github thread, and point the bounty at it?

@PixelantDesign
Copy link
Contributor Author

I didn't love the idea of deleting but was thinking that was the easiest way. I like 2 and 3 since it honors the open source mantra @owocki @thelostone-mc, which do you all prefer?

@owocki
Copy link
Contributor

owocki commented Jun 15, 2018

i think that 3 allows us to workaround the issues with number 1, and thats the reason i'd lean in that direction

@thelostone-mc
Copy link
Member

thelostone-mc commented Jun 17, 2018

I would vote to keep the comments as and use it as is so that whoever is taking up the issue
knows the entire history

There could a number of reasons why it didn't get picked up such as :

  • maybe the issuer kept changing features
  • maybe the issuer/hunter wasn't responsive
  • maybe the hunter didn't have the needed skillset

I don't want to end up in a situation where it feels like we are censoring content. we might get a lot of hate for that

I had spoken about this at a high level with @mbeacom @SaptakS.
They were on the same page

Additionally -> creating a clone issue -> duplicate issue -> increases issue count and that is something folks might not be happy about (might make things confusing ?)

The options suggested by @owocki cannot be generalized (if we decide to provide this to funders ) as it would require asking fore delete permissions (if a user wants to clear up the comments on his issue via a bounty) which we know people will have issues with.

@owocki
Copy link
Contributor

owocki commented Jun 18, 2018

@PixelantDesign whatcha think?

@PixelantDesign
Copy link
Contributor Author

PixelantDesign commented Jun 20, 2018

I think @thelostone-mc brings up a good point. Is there a way to collapse/hide some of the old comments (but leave it on the github thread)?

@thelostone-mc
Copy link
Member

AFAIK it's not possible to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants