Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitcoin completion/funding counts on org icons are incorrect #1404

Closed
mbeacom opened this issue Jun 7, 2018 · 0 comments
Closed

Gitcoin completion/funding counts on org icons are incorrect #1404

mbeacom opened this issue Jun 7, 2018 · 0 comments
Labels
bug This is something that isn't working as intended.

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Jun 7, 2018 •
edited
Loading

User Story

As a user, I would like to see accurate counts on the hover states for organization icons on the profile page.

Why Is this Needed?

Summary: We're displaying inaccurate numbers.

Description

Type: Bug

Current Behavior

screenshot 2018-06-07 16 54 39

It appears to be counting all Bounty objects versus only mainnet.

Expected Behavior

Only display counts for mainnet bounties, not rinkeby.

Reproduction

Visit the profile page and hover over an organization icon. The counts won't match up with the rest of the card.

Solution

Summary: Limit the counting being done here to mainnet or get_network() only.

Definition of Done

The counts are accurate...

Additional Info

Relevant commits:

2ab3c7c
0158a9e
@mbeacom mbeacom added bug This is something that isn't working as intended. profile labels Jun 7, 2018
@owocki owocki closed this as completed in ed36f25 Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is something that isn't working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbeacom