Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG - Black circle on ENS page #1353

Closed
owocki opened this issue Jun 3, 2018 · 9 comments · Fixed by #1354 or #1458
Closed

BUG - Black circle on ENS page #1353

owocki opened this issue Jun 3, 2018 · 9 comments · Fixed by #1354 or #1458
Labels
bug This is something that isn't working as intended.

Comments

@owocki
Copy link
Contributor

owocki commented Jun 3, 2018

http://bits.owocki.com/3I1C1603312N/Screen%20Shot%202018-06-03%20at%205.50.19%20PM.png

Waht is this thing? looks like a regression
@arku
Copy link
Contributor

arku commented Jun 3, 2018

@owocki Let me fix it.

@arku arku mentioned this issue Jun 4, 2018
Merged
3 tasks
@arku
Copy link
Contributor

arku commented Jun 4, 2018

@owocki Submitted a PR. Check it out when you get a chance.

@owocki
Copy link
Contributor Author

owocki commented Jun 14, 2018

@arun1595 this seems to be back

@owocki owocki reopened this Jun 14, 2018
@arku
Copy link
Contributor

arku commented Jun 14, 2018

@owocki Can you share a screenshot?

@owocki
Copy link
Contributor Author

owocki commented Jun 14, 2018

screen shot 2018-06-13 at 8 02 16 pm

@arku
Copy link
Contributor

arku commented Jun 14, 2018

@owocki Weird, let me check and get back to you.

@arku
Copy link
Contributor

arku commented Jun 14, 2018

@owocki The font awesome icon classnames are fine. I guess the font awesome css file isn't loaded in the ENS html page. Will confirm and submit a PR.

@arku arku mentioned this issue Jun 14, 2018
Merged
3 tasks
@arku
Copy link
Contributor

arku commented Jun 14, 2018

@owocki That was the case, the font awesome css file was loaded in a conditional for some reason. I've submitted a PR with a quickfix of moving the link tag outside the conditional. Check it out and let me know if I missed something.

Thanks.

@thelostone-mc
Copy link
Member

Looks like it's working

screen shot 2018-06-14 at 12 13 57 pm

@thelostone-mc thelostone-mc added bug This is something that isn't working as intended. and removed help wanted labels Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is something that isn't working as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix font awesome icon classes arku/web
Fix font awesome loading in ENS page arku/web
3 participants
@owocki @thelostone-mc @arku