Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Stop Work + Stop Work & Slash #1340

Closed
vs77bb opened this issue Jun 1, 2018 · 11 comments · Fixed by #1343
Closed

Admin: Stop Work + Stop Work & Slash #1340

vs77bb opened this issue Jun 1, 2018 · 11 comments · Fixed by #1343

Comments

@vs77bb
Copy link
Contributor

vs77bb commented Jun 1, 2018

User Story

Why Is this Needed?

Currently, slashing conditions are in place for all Gitcoiner's where an admin clicks 'Stop Work'.

Type: Feature

Solution

Summary: Both a 'Stop Work' and a 'Stop Work + Slash' button to differentiate between punishment / no punishment.

screen shot 2018-06-01 at 3 17 48 pm
screen shot 2018-06-01 at 3 17 48 pm

Punishment -- if a user has been slashed, then they cannot start work without asking admins to remove their slash. this is partially implemented already => https://github.com/gitcoinco/web/blob/master/app/dashboard/views.py#L191-L195

Reviewers

@mbeacom @owocki

@vs77bb vs77bb changed the title Stop Work / Stop Work w/ Slash Admin: Stop Work + Stop Work & Slash Jun 1, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.1 ETH (56.61 USD @ $566.12/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Jun 1, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 8 months, 1 week ago.
Please review their action plans below:

1) jvmaia has started work.

work on this issue at this weekend

Learn more on the Gitcoin Issue Details page.

@jvmaia
Copy link
Contributor

jvmaia commented Jun 2, 2018

can i use the issues in the 'rinkeby' network to test the feature?

@jvmaia
Copy link
Contributor

jvmaia commented Jun 2, 2018

both the funder and the staff user have the right to slash, right? or only the staff user?

@vs77bb
Copy link
Contributor Author

vs77bb commented Jun 2, 2018

@jvmaia Hello! Yes - Rinkeby is great for testing.

That's a good question. Let's just give the slashing to the staff users for now. We'll have to consider doing some education for funders before then, IMO.

@jvmaia
Copy link
Contributor

jvmaia commented Jun 2, 2018

Ook, i'm testing it now!

@jvmaia
Copy link
Contributor

jvmaia commented Jun 2, 2018

I'm repairing the user's stop work button, and adding padding to the stop work buttons, commit in 5 minutes

@vs77bb
Copy link
Contributor Author

vs77bb commented Jun 3, 2018

@jvmaia Thanks for the PR! We'll review and get back to you soon if we have any questions. CC @mbeacom @owocki

@jvmaia
Copy link
Contributor

jvmaia commented Jun 3, 2018

Ook, waiting! =)

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.1 ETH (59.72 USD @ $597.22/ETH) has been submitted by:

  1. @jvmaia

@owocki please take a look at the submitted work:


@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.1 ETH (51.54 USD @ $515.36/ETH) attached to this issue has been approved & issued to @jvmaia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants