Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarterly stats v2 - mobile first view #1179

Closed
thelostone-mc opened this issue May 17, 2018 · 46 comments
Closed

quarterly stats v2 - mobile first view #1179

thelostone-mc opened this issue May 17, 2018 · 46 comments
Labels
frontend This needs frontend expertise.

Comments

@thelostone-mc
Copy link
Member

thelostone-mc commented May 17, 2018

Description

make email mobile first view

The base skeleton is already set up @ #1016

Issue: Since the styles are being converted inline -> media queries don't get applied cause the mobile view breakdown

Solution : Rewrite the html skeleton to make the quarterly stats mobile first

must be compatible with

#1036

Due By

Must be merged by the end of June 2018.

@owocki
Copy link
Contributor

owocki commented May 17, 2018

another v2 ticket, which ill bounty the scope of....

@owocki owocki changed the title quarterly stats : mobile first view quarterly stats v2 May 28, 2018
@owocki owocki changed the title quarterly stats v2 quarterly stats v2 - mobile first view May 28, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.1 ETH (52.35 USD @ $523.54/ETH) attached to it.

@Elaniobro
Copy link
Contributor

@thelostone-mc & @owocki Is this going to be a webpage that you can view in the browser, if unable to view on mobile/email client?

@owocki
Copy link
Contributor

owocki commented May 29, 2018

@Elaniobro i wasnt planning on doing that.. i was just planning on making it mobile compatible in email client

@sthorpe welcome! glad to have you on this. wanna submit a WIP PR when you get started? hopefully in the next day or so

@sthorpe
Copy link

sthorpe commented May 30, 2018

@owocki Yup. Do you have a format for our WIPs? I'm gonna get started today. Awww never mind. I found it.

@owocki
Copy link
Contributor

owocki commented May 30, 2018

no format -- just put WIP in the PR title

@gitcoinbot
Copy link
Member

@sthorpe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vs77bb
Copy link
Contributor

vs77bb commented Jun 6, 2018

Hi @sthorpe how is it going here?

@sthorpe
Copy link

sthorpe commented Jun 7, 2018

@vs77bb Hey there! Yes, been distracted with other things lately. I'm back on today.

@mbeacom
Copy link
Contributor

mbeacom commented Jun 7, 2018

@sthorpe Thanks! Feel free to reach out to us on Slack if you have any questions!

@gitcoinbot
Copy link
Member

@sthorpe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sthorpe due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

@rafaelboyero Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link
Member

@rafaelboyero Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k
Copy link
Contributor

shad-k commented Jul 4, 2018

@owocki Can you tell me how can I test the email? I want to make some changes and then test if they are working.

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Jul 4, 2018

@shad-k When you mean test -> you mean just rendering it / actually sending the mail ?
If it's the former - > create a super user (admin) in django and visit the email url defined urls.py and login as the super user

@owocki
Copy link
Contributor

owocki commented Jul 6, 2018

what @thelostone-mc said

@gitcoinbot
Copy link
Member

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shad-k due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@shad-k
Copy link
Contributor

shad-k commented Jul 16, 2018

Sorry, i got distracted with some other things. Will continue working on this and put in a PR by the end of this week.

@gitcoinbot
Copy link
Member

@shad-k Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@shad-k due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vs77bb
Copy link
Contributor

vs77bb commented Jul 30, 2018

@shad-k @thelostone-mc @owocki Should we send this one back out to the crowd?

@shad-k
Copy link
Contributor

shad-k commented Jul 30, 2018

@vs77bb I guess it's already out in the open issues since I clicked on Stop Work on gitcoin 7 days ago.

@gitcoinbot
Copy link
Member

@thelostone-mc @PixelantDesign should we remarket this one / extend the deadline? Know we're still waiting on that feature 🙂

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Aug 10, 2018

Extending issue is complete. We will deploy Monday. @vs77bb @SaptakS

Maybe remarket to see if anyone picks up this weekend?

@alp82
Copy link

alp82 commented Sep 13, 2018

Is this still something that needs to be done? The issue is open but deadline is in the past. Not sure if this needs to be picked up.

@thelostone-mc
Copy link
Member Author

@alp82 yeah have at it ! we'd be happy to tip you out / reopen the bounty if you can get it across the finish line

@usmanmuhd
Copy link
Contributor

@thelostone-mc is this open?

@thelostone-mc
Copy link
Member Author

Ah I think @owocki did push out an update on this! 😅
@owocki do we have anything which needs to be done ?

@owocki
Copy link
Contributor

owocki commented Oct 22, 2018

email could def use some cleanup.. .i just did a quick hackjob

@thelostone-mc
Copy link
Member Author

@usmanmuhd looks like it's up for grabs ^_^

@usmanmuhd
Copy link
Contributor

@thelostone-mc Cool, I'll take this up!

@frankchen07
Copy link
Contributor

hey @usmanmuhd - it looks like you stopped work, are you still working on this?

@usmanmuhd
Copy link
Contributor

@frankchen07 I am interested in doing this, but I have 2 other issues of high priority currently going on. Will take this up once I complete those 2.

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@usmanmuhd
Copy link
Contributor

usmanmuhd commented Nov 15, 2018

If it's the former - > create a super user (admin) in django and visit the email url defined urls.py and login as the super user

@thelostone-mc When I go to the urls defined, it redirects me to a google doc link.
When I run docker-compose up and navigate to localhost:8000/explorer it gives me error. Corresponding logs: https://pastebin.com/s0QM5kZ3

@owocki
Copy link
Contributor

owocki commented Nov 16, 2018

eb_1      | django.db.utils.ProgrammingError: relation "dashboard_searchhistory" does not exist
web_1      | LINE 1: ...ata", "dashboard_searchhistory"."ip_address" FROM "dashboard..

you need to run migrations ./manage.py migrate

@usmanmuhd
Copy link
Contributor

usmanmuhd commented Nov 16, 2018

I am getting this error when I go to http://localhost:8000/_administration/email/quarterly_roundup. https://pastebin.com/anJFNsbW PS: When I comment the line 219 and assign it to zero it displays a page.

In this issue am I supposed to convert all the css to mobile first and then check with the media queries and apply accordingly for larger screens?

@gitcoinbot
Copy link
Member

@usmanmuhd Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@spm32
Copy link
Collaborator

spm32 commented Nov 21, 2018

Hey @thelostone-mc bumping this based on @usmanmuhd's question, any thoughts here?

@thelostone-mc
Copy link
Member Author

@usmanmuhd Ah sorry man ! I'm running on behing on my github notifications
Ideally since this just a FE task -> you can go ahead and hardcode the variables

updating the following should be enough to get the tempalte running.
bounties_completion_percent = (num_completed_bounties / 1) * 100
largest_bounty_value = 0

The end state would be that email shouldn't break on phone / tablets / monitors ( the latter two are already fine)

Just set those two and I was able to get the following

screencapture-localhost-8000-_administration-email-quarterly_roundup-2018-11-23-19_24_22

@gitcoinbot

This comment has been minimized.

@PixelantDesign
Copy link
Contributor

@usmanmuhd does the ^ help?

@vs77bb
Copy link
Contributor

vs77bb commented Jan 14, 2019

@PixelantDesign are we still doing this task? Or should @owocki pull back the funds for it?

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled


The funding of 0.1 ETH (12.79 USD @ $127.88/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

No branches or pull requests