parseTrustedProxies not executed

[xcaptain]

If not using app.Run to run a gin server,

gin/gin.go

Line 344 in caf2802

err = engine.parseTrustedProxies()

won't be executed. and will cause this line not executed

gin/context.go

Line 786 in caf2802

if c.engine.trustedCIDRs != nil {

Which will cause

gin/context.go

Line 735 in caf2802

func (c *Context) ClientIP() string {

not returning the correct ip adress.

I suggest moving this parseTrustedProxies to Default, so c.engine.trustedCIDRs won't be nil.

related issues: #2632

[zihengCat]

What means not using app.Run to run a gin server? Could you give a quick code example?

[xcaptain]

@zihengCat

using

http.ListenAndServe(":8080", router)

or

s.ListenAndServe()

won't execute .Run()

[zihengCat]

@xcaptain
Please waiting for the next release version which provides a SetTrustedProxies API for the purpose.

gin/gin.go

Lines 384 to 388 in 3116a2d

	// SetTrustedProxies set Engine.TrustedProxies
	func (engine *Engine) SetTrustedProxies(trustedProxies []string) error {
	engine.TrustedProxies = trustedProxies
	return engine.parseTrustedProxies()
	}

[zihengCat]

#2692

[xcaptain]

Ok, thanks, but calling SetTrustedProxies every time before start the server is not convinent.

[zihengCat]

@xcaptain
No, calling SetTrustedProxies outside is make sense.

Construct function New create a instance with default TrustedProxies field set. If user wants to change
TrustedProxies, calling another function outside instead of bundle it into initialization seems more suitable .

gin/gin.go

Line 177 in caf2802

TrustedProxies: []string{"0.0.0.0/0"},