Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: $removeparam #4528

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: $removeparam #4528

wants to merge 4 commits into from

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Dec 13, 2024

This adds experimental $removeparam support for adblocker: https://github.com/gorhill/ublock/wiki/static-filter-syntax#removeparam

$removeparam is slightly different from the redirect filters we've seen because multiple filters could interact with single request. We need to clarify the way of providing filters applied.

  • We don't need to run both resource redirect filters and removeparam filters.
  • If we see removeparam filter, we need to prioritize this as it changes the request not the response. Resource redirects can be applied after the request redirect.

TODO

  • Express the situation matching more than one filters: removeparam filters can be more than one per request match
  • Extend redirect scheme defined in BlockingResponse type: this redirect doesn't have contentType and body
  • Parsing regex as value

@seia-soto seia-soto added the PR: New Feature 🚀 Increment minor version when merged label Dec 13, 2024
@seia-soto seia-soto self-assigned this Dec 13, 2024
@seia-soto seia-soto added the WIP label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 Increment minor version when merged WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant